unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34513@debbugs.gnu.org, spacibba@aol.com
Subject: bug#34513: display-line-numbers in term mode
Date: Wed, 27 Feb 2019 12:21:26 -0500	[thread overview]
Message-ID: <jwvva15b17z.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8336o9kvph.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Feb 2019 19:06:02 +0200")

>> How 'bout display-line-numbers-width or display-line-numbers-current-width?
> I think I considered those at the time, but found them not descriptive
> enough.

And how 'bout now?

> And please remember that originally the code was entirely in C, so
> there was no "package name" to use as prefix.

Oh, of course.  But I think in the current context, it would be good to
bring that variable into the "display-line-numbers" prefix.

At first, TAB completion gave me the impression that there was simply no
way to know from Elisp the actual width, because the list of completions
seemed long enough to have the appearance of exhaustiveness.

>> >> -	   (ncols (/ window-width font-width)))
>> >> +	   (ncols (- (/ window-width font-width) (line-number-display-width))))
>> > I think you want (line-number-display-width 'columns), since this
>> > wants the canonical column units, right?
>> Could be, I don't know.  I don't know that all callers of
>> window-max-chars-per-line want that either.
> I hope someone does know.

So do I.  Martin maybe?


        Stefan





  reply	other threads:[~2019-02-27 17:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17 14:19 bug#34513: display-line-numbers in term mode Ergus
2019-02-27 15:26 ` Stefan Monnier
2019-02-27 16:05   ` Eli Zaretskii
2019-02-27 16:40     ` Stefan Monnier
2019-02-27 17:06       ` Eli Zaretskii
2019-02-27 17:21         ` Stefan Monnier [this message]
2019-02-27 17:33           ` Eli Zaretskii
     [not found]           ` <<831s3tkufj.fsf@gnu.org>
2019-02-27 18:00             ` Drew Adams
2019-02-27 18:20               ` Eli Zaretskii
     [not found]           ` <<<831s3tkufj.fsf@gnu.org>
     [not found]             ` <<9f8f0712-1187-4ce3-bd2c-af44cf00927d@default>
     [not found]               ` <<83wolljdpe.fsf@gnu.org>
2019-02-27 19:04                 ` Drew Adams
2020-09-20 18:30   ` Lars Ingebrigtsen
2020-09-20 18:50     ` Eli Zaretskii
2020-09-20 19:56       ` Lars Ingebrigtsen
2020-09-21  2:27         ` Eli Zaretskii
2020-09-21 14:10           ` Lars Ingebrigtsen
2019-02-27 17:46 ` bug#34513: Fwd: " Ergus
2019-02-27 18:15   ` Eli Zaretskii
2019-10-20 22:54 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-21  6:51   ` Eli Zaretskii
2019-10-21 21:44     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-22 15:11       ` Eli Zaretskii
     [not found] <8736fkaish.fsf@aol.com>
2019-10-22 17:33 ` Eli Zaretskii
2019-10-22 23:06   ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-10-23 16:21     ` Eli Zaretskii
2019-10-23 16:50       ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvva15b17z.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=34513@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).