From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#44864: 27.1; advice.el: ad-with-originals deprecated, but no advice on replacement Date: Thu, 26 Nov 2020 10:39:10 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29533"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44864@debbugs.gnu.org To: Julian Gilbey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 16:40:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiJNU-0007XR-6P for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 16:40:12 +0100 Original-Received: from localhost ([::1]:59266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiJNT-0000lN-8m for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 10:40:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiJNL-0000lH-Df for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 10:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59212) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiJNK-0007Em-FI for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 10:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiJNK-0004Nj-Cn for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 10:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44864 X-GNU-PR-Package: emacs Original-Received: via spool by 44864-submit@debbugs.gnu.org id=B44864.160640516616787 (code B ref 44864); Thu, 26 Nov 2020 15:40:02 +0000 Original-Received: (at 44864) by debbugs.gnu.org; 26 Nov 2020 15:39:26 +0000 Original-Received: from localhost ([127.0.0.1]:42525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiJMk-0004Mh-5k for submit@debbugs.gnu.org; Thu, 26 Nov 2020 10:39:26 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiJMi-0004MS-Qi for 44864@debbugs.gnu.org; Thu, 26 Nov 2020 10:39:25 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 339A810024D; Thu, 26 Nov 2020 10:39:19 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3765B10023D; Thu, 26 Nov 2020 10:39:17 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1606405157; bh=dLG1XLd2wTzCGXdHOfhpn4Z2XPoEcuDy1J2DqDKfFjQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dtciPob6Zsh1fanbfJCs6I+XCzhNZ9OSPLWZaGnUJR/TVaBgV6LzGdouPCrDW2H2S ui/bVz49gtZct4Pxk2OfJZjddMoC9typQ0BifPxG8+pwkbY/YTrR5NgidfkVWjvGOO fwwHg4Gu7qM1AvdMOE1gpFSiflyCCYw0i0Ooao6hqJuIeg9LVfwTYJMrQtMIv5nrsf aBMuGY3dcvL/0Afm0ESDdH4rfyFi2+Y8F9OdDFJ2Oe5GJNWdryQIclEUgwSRE+7ev2 FBcievpwh3fFnTzQARq+w+L0jwhFEyOxoC9SUFIUNnFJyrhSxvznUsK5EDGKAZaDKl xlS5m9/bYWeLw== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C9BC6120262; Thu, 26 Nov 2020 10:39:16 -0500 (EST) In-Reply-To: (Julian Gilbey's message of "Wed, 25 Nov 2020 09:00:26 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194347 Archived-At: > ;; Use file's local variables section to set variables in > ;; this buffer. (Don't just copy local variables from the > ;; base buffer because it may have set things locally that > ;; we don't want in the other modes.) We need to prevent > ;; `mode' being processed and re-setting the major mode. > ;; It all goes badly wrong if `hack-one-local-variable' is > ;; advised. The appropriate mechanism to get round this > ;; appears to be `ad-with-originals', but we don't want to > ;; pull in the advice package unnecessarily. `flet'-like > ;; mechanisms lose with advice because `fset' acts on the > ;; advice anyway. > (if (featurep 'advice) > (ad-with-originals (hack-one-local-variable) > (multi-hack-local-variables)) > (multi-hack-local-variables)) The comment doesn't explain why Dave thought that "It all goes badly wrong if `hack-one-local-variable' is advised", so there's not much we can do. AFAIK it will only go wrong with some advice, so he must have had some particular pieces of advice in mind. `advice.el` is deprecated anyway, so my recommendation is to remove this test and just call `multi-hack-local-variables` without paying attention to any potential advice there. If/when you bump into a problem with that, then we'll be able to see what should be done (the best option might be to change the advice itself). > But there is no advice on what to do instead. I think that's because `ad-with-originals` was used on it ;-) Stefan