From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46502: 28.0.50; [feature/native-comp] (d3a399dd) native-comp bootstrap failure Date: Sat, 20 Feb 2021 12:12:54 -0500 Message-ID: References: <87o8gn8ciy.fsf@md5i.com> <83h7m95tt2.fsf@gnu.org> <83ft1s2mp1.fsf@gnu.org> <83a6rz15jm.fsf@gnu.org> <831rdb0yt9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34702"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: mwd@md5i.com, 46502@debbugs.gnu.org, akrl@sdf.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 20 18:14:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDVpb-0008vl-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Feb 2021 18:14:11 +0100 Original-Received: from localhost ([::1]:36806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDVpa-0001a5-DD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Feb 2021 12:14:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDVpS-0001ZJ-UE for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2021 12:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDVpS-0003lH-CH for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2021 12:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lDVpS-0006tu-8S for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2021 12:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Feb 2021 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46502 X-GNU-PR-Package: emacs Original-Received: via spool by 46502-submit@debbugs.gnu.org id=B46502.161384118926441 (code B ref 46502); Sat, 20 Feb 2021 17:14:02 +0000 Original-Received: (at 46502) by debbugs.gnu.org; 20 Feb 2021 17:13:09 +0000 Original-Received: from localhost ([127.0.0.1]:52745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDVoa-0006sP-PN for submit@debbugs.gnu.org; Sat, 20 Feb 2021 12:13:08 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDVoX-0006rp-VD for 46502@debbugs.gnu.org; Sat, 20 Feb 2021 12:13:07 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B528680052; Sat, 20 Feb 2021 12:13:00 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1B6C380229; Sat, 20 Feb 2021 12:12:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1613841175; bh=8Pq+/C43l+uBX0gRNruHI/yUHbxv3CzZqrsf1321A/o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mBNdBrYhd6YTRyQUYBVom5XqZOzlYByrpRKhffulUPlOgrFNjQ67MdRWuJ4BYiYgC jjrH+esS4AUyarYfLmIb2UcK5WD9wXYLJj5x7Gnd9bff0rQy2JWVCvOz6eQ2FuK/hR 0LWslFy9P8Dpgl6M9jYepu+16p3sl469iBAbPU4H8IHbrSThgCmklCrHHPk3fxDZpY Hzt1vKQsltTiXv9+eOKATj/xXuzxkIhTwu6CHAavuAGzPWT4/jf+XRCL9w2qLuqN5R /IaEeLMvKE0t39khCL2l0R+OJgeZQafzxtLXNUvLNCK0cDIqWN/mpNgVpCLzBodNza PGqkpnfUhnoPw== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CC152120416; Sat, 20 Feb 2021 12:12:54 -0500 (EST) In-Reply-To: (Pip Cet's message of "Sat, 20 Feb 2021 17:02:23 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200449 Archived-At: >> One of the possibility is always the inlining (where we either inline >> the source code or the bytecode depending on whether the function to be >> inlined has already been byte-compiled). > That's what it looks like. Are we supposed to fold constants in both cases? Not sure what you mean by "fold constants", but when inlining byte-code we "disassemble" the byte code into LAP code (which is just like byte code but represented as a Lisp list with symbols) an then splice that into the LAP code of the caller. So it tends to lead to slightly less good code because we don't get to apply the source-level optimizer to the combination of the caller and callee (but we still do apply the bytecode (so called "peephole") optimizer). For example, Mattias's new constant propagation code and the resulting constant folding opportunities doesn't work as well. We could change the way `defsubst` works so we *always* inline the source code[1] (but at the cost of having to keep the source code around). But it doesn't seem worth it: we already have `cl-defsubst` which does just that, and we also have `define-inline` which can do an even better job. >> Can you try the patch below to see if it makes a difference? > It does, no difference with the patch. So the effect of the patch is that the build is now (more) reproducible? Stefan [1] except when cross-inlining from different dialects, of course.