From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51523: 29.0.50; gnus-mime-view-part-externally very slow Date: Wed, 03 Nov 2021 08:02:11 -0400 Message-ID: References: <7b7f5641fcf9629c6074@heytings.org> <875ytcwxp7.fsf@gnus.org> <6abcac838b0dd46d94cf@heytings.org> <87sfwgvi73.fsf@gnus.org> <6abcac838bc0f53a0f78@heytings.org> <6abcac838bb83b0904d7@heytings.org> <6abcac838b7f89ee4e21@heytings.org> <831r3zncow.fsf@gnu.org> <6abcac838b521de77925@heytings.org> <83zgqnlt7t.fsf@gnu.org> <87y267revf.fsf@gnus.org> <83v91blrux.fsf@gnu.org> <87o873rdyx.fsf@gnus.org> <83r1bzlrkw.fsf@gnu.org> <87bl33rdrv.fsf@gnus.org> <83mtmnlr93.fsf@gnu.org> <87wnlrpyok.fsf@gnus.org> <6abcac838b9fc735488f@heytings.org> <83sfwek2wu.fsf@gnu.org> <11d5fecb444b249c7dd2@heytings.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7126"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 51523@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 03 13:03:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miEzE-0001gV-Ue for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 13:03:25 +0100 Original-Received: from localhost ([::1]:48348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miEzE-0003rF-2L for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 08:03:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miEys-0003KN-RJ for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 08:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miEys-0000Is-If for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 08:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miEys-0006Sd-GI for bug-gnu-emacs@gnu.org; Wed, 03 Nov 2021 08:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Nov 2021 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51523-submit@debbugs.gnu.org id=B51523.163594094024772 (code B ref 51523); Wed, 03 Nov 2021 12:03:02 +0000 Original-Received: (at 51523) by debbugs.gnu.org; 3 Nov 2021 12:02:20 +0000 Original-Received: from localhost ([127.0.0.1]:39308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miEyC-0006RU-H9 for submit@debbugs.gnu.org; Wed, 03 Nov 2021 08:02:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miEyB-0006RF-8b for 51523@debbugs.gnu.org; Wed, 03 Nov 2021 08:02:19 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A8D59440255; Wed, 3 Nov 2021 08:02:13 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3199F4401D2; Wed, 3 Nov 2021 08:02:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1635940932; bh=VkRvbSW2aizVWayJHNVRd/SMw1Q6zifJfSE80gmNnkw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kYWi2a57q8LiNcPjGwA6UmIcC6oJFv3x/+i1GrWjEWVbudPJgXjkZiE2SisVJxbrn EVNn/mwvp2d2cH1BjardQEXP53JLjLKyWGXjPRQy2Y6B6GaE7YYOSzz/MKTzv11b0S 2coi4PJdKNmOvbzrK4QH1NamhGCIeVsHjMpjlQmpzkc1XQcn+eRQ+KZZ5dhNkzPCnP P9WzG5kZ/UBq5NktR8Lx3UstVT75uagBYuPdzzD+dgdQfzwZTs0alYKECO96J/kVr3 Q/KxT6UKM352bzUrdZEvKHIK08zABeECuCTZr8j0pWNhWTCILJo8Wg00sQJ+k+yuty AYsqDTGtv7dhg== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 01360120262; Wed, 3 Nov 2021 08:02:11 -0400 (EDT) In-Reply-To: <11d5fecb444b249c7dd2@heytings.org> (Gregory Heytings's message of "Wed, 03 Nov 2021 10:45:35 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218860 Archived-At: > I don't know what I should do here. Both Stefan and Lars think (IIUC) that > it's okay to use the filename as is. No: the hash table should be indexed by absolute file names. Anything else will lead to bugs. There are various ways to get those names to be absolute, with tradeoffs. > Using expand-file-name or file-truename also makes that function much > slower: (benchmark-run 100000 (file-has-changed-p "~/.profile")) takes (on > my computer) 2 seconds in its current version, 3 seconds with > expand-file-name, and... 10 seconds with file-truename. In the sample code I sent around this, I used (unless (file-name-absolute-p file) (setq file (expand-file-name file))) in part to avoid the cost of expand-file-name. Stefan