From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53632: Function definition history Date: Fri, 04 Feb 2022 12:14:19 -0500 Message-ID: References: <87y22spdxo.fsf@gmx.de> <87y22qmuro.fsf@gmx.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22208"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Glenn Morris , 53632@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 04 18:36:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nG2VT-0005Tv-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Feb 2022 18:36:24 +0100 Original-Received: from localhost ([::1]:48038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nG2VS-0000dm-Kc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Feb 2022 12:36:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nG2Ap-0005qc-66 for bug-gnu-emacs@gnu.org; Fri, 04 Feb 2022 12:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nG2An-0006Zl-PD for bug-gnu-emacs@gnu.org; Fri, 04 Feb 2022 12:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nG2An-0003Go-LQ for bug-gnu-emacs@gnu.org; Fri, 04 Feb 2022 12:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Feb 2022 17:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53632-submit@debbugs.gnu.org id=B53632.164399486912510 (code B ref 53632); Fri, 04 Feb 2022 17:15:01 +0000 Original-Received: (at 53632) by debbugs.gnu.org; 4 Feb 2022 17:14:29 +0000 Original-Received: from localhost ([127.0.0.1]:60969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nG2AH-0003Fi-KB for submit@debbugs.gnu.org; Fri, 04 Feb 2022 12:14:29 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nG2AG-0003FU-7t for 53632@debbugs.gnu.org; Fri, 04 Feb 2022 12:14:28 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8DDAE4415FD; Fri, 4 Feb 2022 12:14:22 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0E46D4415F7; Fri, 4 Feb 2022 12:14:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1643994861; bh=4X0pe6Mg2+YZZ8uT5SlhDxrT2wIuiNLmMbxaKn8Ssog=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MqrrBzhkhd5SqIWxfC4wMpjJ5R+ZAv7H2f/0+D9Ui0sWAchfn8OfDrAULmgMSfNV3 b/FPN9ZQ6FuCr+coJRZxbWrtIvrXsylZJxP4gC9uDQKB31t/C0G0v+mhKaGyIesVBt X/+wPqHhEVkMKXgmfTHY9gsc9VidRbTbvL09jxgqEz+pnSH+xFqqnfeQdkrw+VScgN /p8GAGbSGg2M27GBS4sQBKt4vvACZ/1FDWMuF//W6xwZPZW4Tdde1HGDorBL/KvjaC 3FbF+EpK8lGHA0TCgG6XAq079LgzwKrLLFDMRqi13UEcxvqFyn+EesWXPTyuiSdI4f CKvltlU1B/gzQ== Original-Received: from pastel (76-10-138-212.dsl.teksavvy.com [76.10.138.212]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A518B1206C9; Fri, 4 Feb 2022 12:14:20 -0500 (EST) In-Reply-To: <87y22qmuro.fsf@gmx.de> (Michael Albinus's message of "Fri, 04 Feb 2022 18:00:43 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226010 Archived-At: >> So I think the problem is in the test rather than in the unload code. >> The patch below fixes the test for me. > > The patch essential is to list those functions, and to make an > exception. Will work, yes. However, I fear that this is error-prone: > Whenever there is another such function with an autoload cookie in the > future, the test will fail, again. > > Perhaps we shall give these functions a symbol property, say > `tramp-autoload', and test for that property in order to filter out? > This should be more robust. Maybe a simpler option is to give them a recognizable name (e.g. including "preloaded" or "AL" or somesuch in their name)? In any case, those parts of the test47 are actually testing loadhist.el rather than Tramp, so I'd recommend you don't worry too much about those functions. I'd focus instead on the parts that verify proper functioning of the code you put in `tramp-unload-hook`. Stefan PS: BTW, why is `tramp-unload-file-name-handlers` preloaded? It doesn't seem like it can be meaningfully used before Tramp is loaded.