From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45767: bug#45768: icomplete-mode does not provide in region completion for dabbrev-completion Date: Fri, 06 May 2022 15:38:54 -0400 Message-ID: References: <255598638.117929.1610282275124@office.mailbox.org> <87k0ayh499.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23898"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 45768@debbugs.gnu.org, simon254@mailbox.org, 45767@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 06 21:40:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nn3oC-00061l-Rn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 May 2022 21:40:12 +0200 Original-Received: from localhost ([::1]:42566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nn3oB-0002IQ-MB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 May 2022 15:40:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nn3o3-0002I7-AX for bug-gnu-emacs@gnu.org; Fri, 06 May 2022 15:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nn3o2-0003Hu-EO for bug-gnu-emacs@gnu.org; Fri, 06 May 2022 15:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nn3o2-0002AY-CD for bug-gnu-emacs@gnu.org; Fri, 06 May 2022 15:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 May 2022 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45767-submit@debbugs.gnu.org id=B45767.16518659538269 (code B ref 45767); Fri, 06 May 2022 19:40:02 +0000 Original-Received: (at 45767) by debbugs.gnu.org; 6 May 2022 19:39:13 +0000 Original-Received: from localhost ([127.0.0.1]:49916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nn3n7-000299-4f for submit@debbugs.gnu.org; Fri, 06 May 2022 15:39:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nn3n4-000281-Uu; Fri, 06 May 2022 15:39:04 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 138B910029F; Fri, 6 May 2022 15:38:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C291F10012C; Fri, 6 May 2022 15:38:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651865935; bh=cpEY8q+z55x8ulUhV+lT3zFWd8TRQIaKe2eP/No8Znc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D/MtsB3x+cmuDYhTItU5AmGfsRtkONxolnp7gmGQ89NliYFvn23MNDEDSmtH0V5zK 5uPDzIDgsJZ7zD8XOIi1VXddMw/grAl3qeYbULEczpuTakzHivhDIgtkaHX50wyoJo voJKANLnm9sx91qognJmbtFpWnGpn27ZwqV22LfQti/kshcD0+wIM7hsXpU3bgLOpb LUQDuw1s2d4+77FbxWoVDObniVxmyT+z6Anbv2Dio0aNh31ix4Tk1PlUd2pYLVtaHd 5X83qJjUKhPRzC9eNn7VWNcoms83eonhyqNItCchY5GPyCH5kiUw0yQiXAWjBl4TKx O582EjT7bHTUw== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 921B31206AC; Fri, 6 May 2022 15:38:55 -0400 (EDT) In-Reply-To: <87k0ayh499.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 06 May 2022 21:04:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231541 Archived-At: Lars Ingebrigtsen [2022-05-06 21:04:18] wrote: > simon254@mailbox.org writes: > >> emacs -Q >> in *scratch* evaluate >> (setq icomplete-in-buffer t) >> (icomplete-mode t) >> >> type: >> asdf1 >> asdf2 >> asdf followed by C-M-/ (dabbrev-completion) >> -> default completion is invoked, not icomplete-mode > > (I'm going through old bug reports that unfortunately weren't resolved > at the time.) > > I can reproduce this on the current trunk, too, but skimming the code, > I'm not quite sure how this is supposed to work. I've added Stefan to > the CCs; it looks like he added the icomplete-in-buffer thing back in > 2013. The problem is that `icomplete-in-buffer` relies on `completion-in-region-mode-predicate` being passed to `completion-in-region` (this is needed so Icomplete can know when you've finished the completion), which `completion-at-point` does but which `dabbrev-completion` does not do, so `icomplete-in-buffer` is not used when completing via `dabbrev-completion`. Stefan