From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 61778@debbugs.gnu.org
Subject: bug#61778: 30.0.50; [PATCH] Be more cautious in completing Eshell variable assignments
Date: Sat, 25 Feb 2023 18:25:06 -0500 [thread overview]
Message-ID: <jwvv8jpmiqp.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f05befd4-91ae-2572-cd36-54282c0f8324@gmail.com> (Jim Porter's message of "Fri, 24 Feb 2023 22:02:14 -0800")
> After quite a bit of digging, I figured out the issue: Eshell was treating
> "--directory=" as the beginning of a local variable assignment (like when
> you run "CC=gcc make"). The function 'eshell-complete-variable-assignment'
> is over-aggressive in identifying local variable assignments, and so it
> picked this up as a false positive.
>
> Attached is a fix for this, plus a regression test.
LGTM, thanks,
Stefan
next prev parent reply other threads:[~2023-02-25 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 6:02 bug#61778: 30.0.50; [PATCH] Be more cautious in completing Eshell variable assignments Jim Porter
2023-02-25 23:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-26 4:40 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvv8jpmiqp.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=61778@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).