From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64417: 30.0.50; keymap-unset :REMOVE keyword not working Date: Sun, 02 Jul 2023 17:41:15 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13895"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64417@debbugs.gnu.org To: German Pacenza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 02 23:42:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qG4pm-0003P2-8p for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jul 2023 23:42:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qG4pY-0001Hj-KT; Sun, 02 Jul 2023 17:42:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG4pW-0001HH-SX for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 17:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qG4pW-00078O-Jv for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 17:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qG4pV-0002HS-Ss for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 17:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2023 21:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64417 X-GNU-PR-Package: emacs Original-Received: via spool by 64417-submit@debbugs.gnu.org id=B64417.16883340878721 (code B ref 64417); Sun, 02 Jul 2023 21:42:01 +0000 Original-Received: (at 64417) by debbugs.gnu.org; 2 Jul 2023 21:41:27 +0000 Original-Received: from localhost ([127.0.0.1]:32848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG4ox-0002Gb-Dj for submit@debbugs.gnu.org; Sun, 02 Jul 2023 17:41:27 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG4os-0002GJ-Ik for 64417@debbugs.gnu.org; Sun, 02 Jul 2023 17:41:26 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EC707805BF; Sun, 2 Jul 2023 17:41:16 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E35E0802A7; Sun, 2 Jul 2023 17:41:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688334075; bh=kCavhfXKOAmJA7b5E/QHIzd4qTdSdFLIHnnCUU9jXPM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Axj5cWxnvbbgtLWG/qiAwy0JCVp3I8Chizzeu4GPKhh/x5fHFUahrWM4xeif8gnA0 NAaND171HMymYLYqDUZCcB01eSn48H/cpO1gbVHJzOWABId+WMBSisPTsnGFBTOtg+ 4IerVKP8QcadsqFv4s49F3RXgAGBj7OAP8WadsvSI5qGzi652WLb0ChrVqqAEQ695z JZ3GPAOIgw8i6a4N5VuNf8UZ9no7lasxw429W8/K1pzcUh8V2QcncBafuCqYHUQlq3 9MCTosCgH9CgFiXH33WUqBxCZtKAccVvIg0+IBg6fnrFGVT/4Eb3JzpfpuSi07Bimr D63kFRXPxx+jQ== Original-Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BD4491202A5; Sun, 2 Jul 2023 17:41:15 -0400 (EDT) In-Reply-To: (German Pacenza's message of "Sun, 02 Jul 2023 13:54:38 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264500 Archived-At: > Don't add a key binding when REMOVE is non-nil > > * src/keymap.c (store_in_keymap): Don't add a nil keybinding if we've > been asked to remove a non-existent binding. (Bug#62207) > > What I do is setting M-SPC in global-map to 'execute-extended-command' > That gets shadowed by diff-mode-map to run 'scroll-up-command', so I use > keymap-unset with :REMOVE to remove it. `remove` is for the case where you want to unhide the keybinding of a *parent* map (that's an unusual use-case). Here OTOH you want to unhide the keybinding of a lower-precedence map, so you shouldn't use `remove`. > Currently keymap-unset removes the binding _without_ :REMOVE and doesn't > do anything _with_ :REMOVE. If it hurts, don't do that :-) Stefan