From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47711: bug#48841: bug#47711: bug#48841: bug#47711: [PATCH VERSION 2] Add new `completion-filter-completions` API and deferred highlighting Date: Sun, 29 Oct 2023 00:41:37 -0400 Message-ID: References: <3d3f894f-a6fa-53ae-5d50-c3aa9bffc73e@daniel-mendler.de> <56ab18b1-4348-9b2c-85bb-af9b76cd429a@daniel-mendler.de> <328f87eb-6474-1442-e1ca-9ae8deb2a84a@yandex.ru> <83fsvcbio7.fsf@gnu.org> <9f432d18-e70f-54c1-0173-1899fb66d176@gutov.dev> <877cnafv39.fsf@gmail.com> <9447dde3-b8e7-2ec0-9a9c-72c4cf9d12a8@gutov.dev> <7d14bc13-4419-816c-5708-c42988c39c02@gutov.dev> <5d0a78cc-4fa0-ef04-3462-1826f17d7d56@gutov.dev> <1504b2e4-42d9-5d7b-eaa2-c7b7d5ca02ba@gutov.dev> <40ddec76-751a-36cd-7f45-34de2d9d9393@gutov.dev> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38809"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Daniel Mendler , Eli Zaretskii , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 47711@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 29 05:42:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qwxdY-0009tU-Nb for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Oct 2023 05:42:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwxdC-0001an-3n; Sun, 29 Oct 2023 00:42:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwxd8-0001aO-AV for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 00:42:30 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwxd7-0006qW-Ga for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 00:42:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwxdd-0001jk-My for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 00:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2023 04:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47711 X-GNU-PR-Package: emacs Original-Received: via spool by 47711-submit@debbugs.gnu.org id=B47711.16985545416627 (code B ref 47711); Sun, 29 Oct 2023 04:43:01 +0000 Original-Received: (at 47711) by debbugs.gnu.org; 29 Oct 2023 04:42:21 +0000 Original-Received: from localhost ([127.0.0.1]:40225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwxcy-0001io-SK for submit@debbugs.gnu.org; Sun, 29 Oct 2023 00:42:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwxcw-0001iZ-IV for 47711@debbugs.gnu.org; Sun, 29 Oct 2023 00:42:19 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6E09480060; Sun, 29 Oct 2023 00:41:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1698554498; bh=Cvxbx19Q0HisO66IOuLRjPmBNohSpiCqcjIzyzZxl4U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=b8DznH+2f9aGHPnOYOVSKO6LHPA3fP77hXmL17FGBty7RPi0aoyNTyVUvc4VTuK44 sN9eayDW1JjoqWAB+lTobtLTmBDN0r8nnf8gdig7AbKJJoq+5w9mzGkwc0X14jxFFz wj8ne4SqMQFB2cPn02OqV7Z8seyvPkii1WBCKt+tQiDye6loRWMZf+/GB3pF7bb1aS zN6cisaYKH4rbyOABpkefLhWKVkFLtmxSQRO43qRVjPX+3qKWMClU/EHGmvxng0oJQ VyBexlcel4LOuasaALnUSGqCbVZA3VYkQM1fgHWcyzhxq26OxlMCwnvltF71ezQIV5 +3RRd6+0zFGWQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AF24D80667; Sun, 29 Oct 2023 00:41:38 -0400 (EDT) Original-Received: from pastel (unknown [45.72.195.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 74B1A12016C; Sun, 29 Oct 2023 00:41:38 -0400 (EDT) In-Reply-To: <40ddec76-751a-36cd-7f45-34de2d9d9393@gutov.dev> (Dmitry Gutov's message of "Sun, 29 Oct 2023 04:07:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273480 Archived-At: > FWIW, this neat structure might not help too much: the most popular external > completion backend (the LSP language servers, collectively) don't accept > regexps or globs, they just send you the lists of completions available at > point. With the name matching method sometimes configurable per-server. Largely agreed. The main benefit tho is that you get just *one* pattern, rather than three (one being the prefix argument, the second being the `pred` arg which historically was so unused that it was abused to hold the directory for file-name completion, so lots of tables don't obey it, and the third being the `completion-regexp-list` that most coders forget, and those who don't end up regretting not forgetting when it was not meant for them), so it's much more clear. > As such, the most useful methods currently are: 1) Emacs Regexp, 2) asking > server for whatever it thinks is suitable (the "backend" completion style). For the backends: agreed. For the frontends (i.e. `completion-styles`), `glob` is the more useful one, I'd say (except for the "external" style, of course). We might also want support for things like `or` and `and` patterns, but I haven't managed to fit them nicely in that structure :-( > I would also probably want to standardize on the recommended type of TO > anyway: some of them are likely going to result in better performance > than others. The TO is chosen by the specific completion table, based on what it can handle best. So it should always be "optimal". > So I guess it's also a way to make every completion table aware of PRED? Note also that these `pred` patterns are expected to be exclusively looking at the string (they're used for `completion-styles` kind of functionality), so nothing like `file-directory-p` or `fboundp` kind of predicates here. The `pred`s used in things like `completing-read` and `read-file-name` would be handled elsewhere such as `completion-table-with-predicate`. This part is still up in the air, tho. > That should work; though it might be hard to reach the same raw performance > as the current all-completions + completion-regexp-list. I don't see why: currently my code actually uses `all-completions` and `completion-regexp-list`, so as long as the pattern can be turned into a regexp without requiring an additional PRED (that's usually the case), it should be just as fast (at least for large tables; for small tables we have the overhead of the various method calls and pattern conversions, of course). Stefan