From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67124: 26.3; query-replace Arg out of range with comma option (at end-buffer) Date: Thu, 16 Nov 2023 13:01:27 -0500 Message-ID: References: <020a72b2-b896-4ecf-abab-111a6c1c9eac@medialab.sissa.it> <83cywfuwta.fsf@gnu.org> <83pm0du49e.fsf@gnu.org> <83o7ftpx1w.fsf@gnu.org> <83jzqhprhb.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38044"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gabriele@medialab.sissa.it, 67124@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 16 19:02:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3gh7-0009gf-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Nov 2023 19:02:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3ggn-00014h-Pw; Thu, 16 Nov 2023 13:02:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3ggl-000117-Ps for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 13:02:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3ggl-000360-HP for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 13:02:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3ggk-0001Ry-IN for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 13:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2023 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67124 X-GNU-PR-Package: emacs Original-Received: via spool by 67124-submit@debbugs.gnu.org id=B67124.17001576965538 (code B ref 67124); Thu, 16 Nov 2023 18:02:02 +0000 Original-Received: (at 67124) by debbugs.gnu.org; 16 Nov 2023 18:01:36 +0000 Original-Received: from localhost ([127.0.0.1]:44467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3ggK-0001RF-2y for submit@debbugs.gnu.org; Thu, 16 Nov 2023 13:01:36 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3ggH-0001R2-WD for 67124@debbugs.gnu.org; Thu, 16 Nov 2023 13:01:34 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CA1FC804F5; Thu, 16 Nov 2023 13:01:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700157687; bh=+kimbcJuLh81j3ootCUrDw9pti/rnYQcLqY80BYFyRs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kFi3qNIIYiIDLVfV+v14q3uDjoSM+yhrg1rAg2MNmC1vxDZO6oZmXJxkL68NBcPCp XWWdIKUBOPuWZ2NNiRT3NCSZ+P+jvw53BFW5+4ikXOBVDGO8UYYJgefCisgITX7i/f iABrRBvIbd4X01AQkBSpzLx9pboDfCChHReG7AsN8x5ZKazxomLKtd7NTrZBrL4xAD Y5kCsCrxOqQfYyMbnaVzKBuWVfUNsaYqZUIHXjVK3EHNAFBbnTmrqqAxJnDuwe+LQs g2G/C7aJTxqFF3nzSWyj4ZoUbteT16tvFJ9+Px1882+dwsexpYmsdbmcOtOft9hwF+ KZgnClaH7mw3w== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D811D80385; Thu, 16 Nov 2023 13:01:27 -0500 (EST) Original-Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AC5CA12049E; Thu, 16 Nov 2023 13:01:27 -0500 (EST) In-Reply-To: <83jzqhprhb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Nov 2023 18:56:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274475 Archived-At: >> > What are you trying to understand? >> >> Why you're saying that in >> >> ;; `replace-match' leaves point at the end of the replacement text, >> ;; so move point to the beginning when replacing backward. >> (when backward (goto-char (nth 0 match-data))) >> >> it is not true that >> >> and (nth 0 match-data) == (match-beginning 0), no? > > Because of markers vs positions, as I've tried to explain. The > difference is minor, of course. But `goto-char` doesn't care about that difference, and no buffer will be changed between the time we call `match-data` (thus creating the markers) and the time we use those markers, so going through markers is just extra work for no benefit. IOW, I still don't understand how "markers vs positions" is relevant in (when backward (goto-char (nth 0 match-data))) >> > What my kludge did is simply use a marker, so the adjusted position is >> > not clobbered. >> >> I don't see that. E.g. if you change your code from >> >> (set-match-data (list (car match-data) (nth 1 (match-data)))) >> to >> (set-match-data (list (car match-data) (nth 1 (match-data t)))) >> >> it fixes the problem just as well, AFAICT. > > Yes, but match-data (the function) returns updated positions, which > behave like markers across the replace-match call. But the positions have already been updated. So (match-data t) would also return those updated positions, even though it doesn't use markers. Stefan