From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69832: 30.0.50; Should `subr-primitive-p` apply to special-forms? Date: Sat, 16 Mar 2024 15:58:09 -0400 Message-ID: References: <86il1m55bk.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21422"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69832@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 16 20:59:46 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlaC1-0005L7-Ou for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Mar 2024 20:59:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlaBk-0000qT-Or; Sat, 16 Mar 2024 15:59:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlaBi-0000qD-Ef for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 15:59:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlaBi-0004fo-6d for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 15:59:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rlaCJ-0003B8-0P for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 16:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Mar 2024 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69832 X-GNU-PR-Package: emacs Original-Received: via spool by 69832-submit@debbugs.gnu.org id=B69832.171061914212099 (code B ref 69832); Sat, 16 Mar 2024 20:00:02 +0000 Original-Received: (at 69832) by debbugs.gnu.org; 16 Mar 2024 19:59:02 +0000 Original-Received: from localhost ([127.0.0.1]:56487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlaBK-00038u-0Z for submit@debbugs.gnu.org; Sat, 16 Mar 2024 15:59:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlaBH-00038X-TE for 69832@debbugs.gnu.org; Sat, 16 Mar 2024 15:59:00 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BEE361000DD; Sat, 16 Mar 2024 15:58:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1710619091; bh=skY08CUkPSq4dVlUnEcig40pOMGE0C6bLSk6fXDqfFE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=l6IRsdfq/VqR5dFbGXqEpRZMmTT8sP8CSeZM6siyXGqUEZ0IRJcBJcYaLIZoLSRoU FnttP1NaKXgjtUvhWmCGCKfS/MT4yRvEdD6AfKBcv840x1tuH6suvnnJvk6ZMVPv7J z1wZg1pG64AKLK+xHQbJp2DdcJ9rARjC0sHWZChHNlV1qQ8V4zV3hWEsMsIVOUSTbk XhzcJ0vp6MXf4QHFC1EqNZ/Q7NxZyZYDP51dMjcHeks6K/yQniQw3oC6IcpHP0g8lE RDo9yBvIXYsWr8TtrbjU6X9U8CSZaMzwON6WkLCkGgy0uwGyR51kWp/VUfVJFegODP gwV0s5o1sq95g== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5057B100048; Sat, 16 Mar 2024 15:58:11 -0400 (EDT) Original-Received: from pastel (unknown [104.247.238.200]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2D58D120495; Sat, 16 Mar 2024 15:58:11 -0400 (EDT) In-Reply-To: <86il1m55bk.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Mar 2024 21:45:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281736 Archived-At: >> I can see two ways to fix that: >> >> - Introduce a new type, says `subr-function(-p)` which returns non-nil >> if and only if the argument is a built-in primitive *and* a function. >> >> - Change the implementation of `subr-primitive-p` to match its docstring. >> >> The patch below does the second (including changing the only place >> I found that wants the current semantics. >> >> Comments? Objections? > > Why take the path of a breaking change instead of the non-breaking > alternative? - It can be considered as a bug fix (to make the code match its doc). - If we introduce `subr-function-p`, then `subr-primitive-p` is only "useful" at one place any more, and we can trivially rewrite the code to avoid it, so we could get rid of it. - These functions are used very rarely, the majority is in core files, and the rest is mostly used to generate human-facing descriptions so the risk of breakage is low and the kind of breakage is likely to have a low impact. Stefan