From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer) Date: Wed, 24 Apr 2024 10:26:40 -0400 Message-ID: References: <86ttjr2pzw.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4552"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: rcopley@gmail.com, 70541@debbugs.gnu.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 24 16:28:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzdbh-0000w0-8H for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Apr 2024 16:28:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzdbJ-0001WR-Fg; Wed, 24 Apr 2024 10:27:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzdbH-0001WC-Sw for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 10:27:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzdbH-0002Ih-Kb for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 10:27:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzdbY-0007rM-9H for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 10:28:12 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2024 14:28:11 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70541 X-GNU-PR-Package: emacs Original-Received: via spool by 70541-submit@debbugs.gnu.org id=B70541.171396883729647 (code B ref 70541); Wed, 24 Apr 2024 14:28:11 +0000 Original-Received: (at 70541) by debbugs.gnu.org; 24 Apr 2024 14:27:17 +0000 Original-Received: from localhost ([127.0.0.1]:58732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzdaY-0007hO-US for submit@debbugs.gnu.org; Wed, 24 Apr 2024 10:27:15 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzdaT-0007fK-O7 for 70541@debbugs.gnu.org; Wed, 24 Apr 2024 10:27:07 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 92F4B80B0E; Wed, 24 Apr 2024 10:26:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1713968801; bh=c0lFAawfONJpcVLUCJdcDU1yRkZUSPcOC5WB9Zb3cqI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Z8h4PtfJfzDZ/TLNsibo0itRkVwsdTsyxU+BsGxqJhvjEQoWMi0xtBrJ7Ys1Ojey2 XJIdYb9obm/GwoS//IPDS87gTsEvJmNAQ5rOfa1FYkqGXdhvAh9f5GLeA2Ig5ozkmb uKmzPwCrYlc9FeUyVoiFVm2h0uINiMXFIhzXx0dTlpYwuaTBS5XOo7t8MrPzFB+Rtc hFhFKhSeVYG6sfhjHEgb+EB9EK00Zcc23hQFLnlUBtpXtK8b68RQuE9/qYCmSLoZKP vXjqqzKHz3hmN+pVtGI0aKO8MRcoum6mJ8TfdPIL5RPMCQj/9FuRpv6PJvyvYqLZ4v Z4E1+JmT0qQDw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9749B800A0; Wed, 24 Apr 2024 10:26:41 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 67CCB1204B3; Wed, 24 Apr 2024 10:26:41 -0400 (EDT) In-Reply-To: <86ttjr2pzw.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 24 Apr 2024 10:12:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283917 Archived-At: > Are you sure we want buffer-change hooks to be called here? Adding/removing chars from the buffer without running those hooks breaks all kinds of assumptions. It can be acceptable to do it in a very temporary way, but Quail doesn't do it temporarily: the whole redisplay+timers+filters gets run in the middle of the input of any multi-key entry like `^a`, so the "temporary" state is very much exposed. > Quail intentionally hides some of the modifications it does, because > it many times replaces the inserted text with something else, and from > the Emacs Lisp program's POV only the final input is the actual > "insertion" Emacs should know about. I'm not sure why it's important to hide the intermediate steps, especially since they're not very well hidden (as evidenced by this bug report, and by the fact that font-lock is also triggered every time the transient display is modified). Note that when users use Abbrev instead to turn \lambda into =CE=BB, the intermediate steps are not hidden, and that's not been a problem. > So I'm not sure we should install this, as it could break something > elsewhere. Aren't there any alternatives to this? We could change Quail so it refrains from temporarily modifying the buffer, using an `after/before-string` on an overlay instead. It'd be a fairly significant change in `quail.el` and would probably come with its own share of problems. > More generally, > why should Eglot care about these low-level details of Quail? Because Eglot syncs up with the LSP server via a timer, so it sees the buffer with an extra "^" char in it. Stefan