From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: xah lee <xah@xahlee.org>
Cc: bug-gnu-emacs@gnu.org, 1286@emacsbugs.donarmstrong.com,
bug-submit-list@donarmstrong.com
Subject: bug#1286: comment-dwim on a comment line does not toggle comment
Date: Tue, 04 Nov 2008 11:34:33 -0500 [thread overview]
Message-ID: <jwvtzanqwqa.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <244A228E-2192-4165-8495-C760C253DE9E@xahlee.org> (xah lee's message of "Mon, 3 Nov 2008 13:10:24 -0800")
> when a cursor is on a comment line (whole line is comment) and there's no
> active region, i don't see any reason it shouldn't just uncomment the line
> when calling comment-dwim. I would say that, any person, including those
I, on the other hand, don't see why it should do that. What would be
the logic behind it? And according to that logic what should it do if
the line contains a comment as well as some code?
As explained, the M-; behavior you're seeing has been with us for many
many years, so there needs to be a good reason for the change (and the
previous behavior of inserting a comment marker and/or reindenting
a preexisting comment marker, should still be available somewhere).
Stefan
next prev parent reply other threads:[~2008-11-04 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwvabcknsf4.fsf-monnier+emacsbugreports@gnu.org>
2008-10-31 21:25 ` bug#1286: comment-dwim on a comment line does not toggle comment xah lee
2008-11-01 1:40 ` bug#1286: marked as done (comment-dwim on a comment line does not toggle comment) Emacs bug Tracking System
2008-11-03 11:25 ` bug#1286: comment-dwim on a comment line does not toggle comment Xavier Maillard
2008-11-03 21:10 ` xah lee
2008-11-04 16:34 ` Stefan Monnier [this message]
2008-11-05 7:25 ` Xavier Maillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtzanqwqa.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=1286@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=bug-submit-list@donarmstrong.com \
--cc=xah@xahlee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).