From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitriy Blinov <bda@mns.spb.ru>
Cc: 1537@emacsbugs.donarmstrong.com
Subject: bug#1537: diff-mode for git patches trouble
Date: Fri, 12 Dec 2008 14:08:19 -0500 [thread overview]
Message-ID: <jwvtz99rz7n.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <49420B4F.9000902@mns.spb.ru> (Dmitriy Blinov's message of "Fri, 12 Dec 2008 09:57:19 +0300")
severity 1537 wishlist
thanks
>> Of course, in the general case the problem is insoluble (e.g. if you
>> edit the line with the "--"), but clearly we can do better in the
>> "normal" case.
> Probably it was incorrect to post this feature here. In fact it's git
> problem but not emacs.
No, it definitely has its place here: while it's true that Git's output
is not very friendly to patch-editing as supported by diff-mode, the
output is formally correct and unambiguous.
And your example of changes is also unambiguous, so you can definitely
argue that Emacs should behave correctly in this case.
Stefan
next prev parent reply other threads:[~2008-12-12 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 13:08 bug#1537: diff-mode for git patches trouble Dmitriy Blinov
2008-12-11 19:04 ` Stefan Monnier
2008-12-12 6:57 ` Dmitriy Blinov
2008-12-12 19:08 ` Stefan Monnier [this message]
2008-12-12 19:15 ` Processed: " Emacs bug Tracking System
2020-08-16 17:00 ` bug#1536: " Stefan Kangas
2020-10-14 6:08 ` bug#1537: " Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtz99rz7n.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=1537@emacsbugs.donarmstrong.com \
--cc=bda@mns.spb.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).