From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11095: [PATCH] Re: bug#11095: 24.0.94; hi-lock-face-buffer/unhighlight-regexp': Augment? Date: Thu, 06 Dec 2012 14:16:57 -0500 Message-ID: References: <81d37z271c.fsf@gmail.com> <87626i2i4r.fsf@gmail.com> <87zk1r3h3b.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354821480 4133 80.91.229.3 (6 Dec 2012 19:18:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Dec 2012 19:18:00 +0000 (UTC) Cc: 11095@debbugs.gnu.org To: Jambunathan K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 06 20:18:13 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TggxY-0002NH-Km for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Dec 2012 20:18:12 +0100 Original-Received: from localhost ([::1]:51781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TggxM-00007R-Iy for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Dec 2012 14:18:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TggxD-000073-Ph for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2012 14:17:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tggx9-0007DK-JK for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2012 14:17:51 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tggx9-0007DE-Fg for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2012 14:17:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TggxN-00073N-Ih for bug-gnu-emacs@gnu.org; Thu, 06 Dec 2012 14:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Dec 2012 19:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11095-submit@debbugs.gnu.org id=B11095.135482143627011 (code B ref 11095); Thu, 06 Dec 2012 19:18:01 +0000 Original-Received: (at 11095) by debbugs.gnu.org; 6 Dec 2012 19:17:16 +0000 Original-Received: from localhost ([127.0.0.1]:57192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tggwd-00071Y-Hw for submit@debbugs.gnu.org; Thu, 06 Dec 2012 14:17:16 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:47179) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tggwb-00071N-4z for 11095@debbugs.gnu.org; Thu, 06 Dec 2012 14:17:14 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09soXOY/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="209237591" Original-Received: from 108-161-115-152.dsl.teksavvy.com (HELO pastel.home) ([108.161.115.152]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Dec 2012 14:16:58 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id AF4B658F5C; Thu, 6 Dec 2012 14:16:57 -0500 (EST) In-Reply-To: <87zk1r3h3b.fsf@gmail.com> (Jambunathan K.'s message of "Thu, 06 Dec 2012 10:36:00 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68043 Archived-At: > (get-char-property (point) 'face) > : "hi-yellow" I just fixed that a little while ago. > Issue-2: Various issues with unhighlighting > ============================================ > Once you fix Issue-1 you will run in to other issues with > un-highlighting. Try highlighting and UN-highlighting in following 3 > ways > 1. Buffer with font-lock-mode ON > 2. Buffer with font-lock-mode OFF > 3. Unhighlight from the menu Seems to be working now (haven't tried before my recent changes, tho). > (defcustom hi-lock-face-defaults > '(hi-yellow hi-pink hi-green hi-blue hi-black-b > hi-blue-b hi-red-b hi-green-b hi-black-hb) > "Default faces for hi-lock interactive functions." > :type '(repeat face) > :group 'hi-lock-faces) I think it'd be important to make it possible/easy for the user to add new faces of his own creation in there. So we'd need a :setter that creates those faces as needed. BTW, I wouldn't spend too much time on hi-lock-auto-select-face since setting it to t just saves you from typing RET RET instead of RET. I'm not even sure we want to keep such configuration. Stefan