From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13207: lisp-mnt.el improvements Date: Mon, 17 Dec 2012 20:29:22 -0500 Message-ID: References: <878v8wve4m.fsf@bernoul.li> <8738z42vel.fsf@bernoul.li> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1355794189 1914 80.91.229.3 (18 Dec 2012 01:29:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Dec 2012 01:29:49 +0000 (UTC) Cc: 13207@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 18 02:30:04 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tkm0Q-0005sa-RB for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Dec 2012 02:30:02 +0100 Original-Received: from localhost ([::1]:39318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkm0D-0000Ro-Cl for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2012 20:29:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkm0A-0000RY-Pa for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 20:29:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tkm09-0006zf-1Y for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 20:29:46 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkm08-0006zb-UO for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 20:29:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tkm1O-0003jd-52 for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 20:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Dec 2012 01:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13207 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13207-submit@debbugs.gnu.org id=B13207.135579424114326 (code B ref 13207); Tue, 18 Dec 2012 01:31:02 +0000 Original-Received: (at 13207) by debbugs.gnu.org; 18 Dec 2012 01:30:41 +0000 Original-Received: from localhost ([127.0.0.1]:47835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tkm13-0003j1-DY for submit@debbugs.gnu.org; Mon, 17 Dec 2012 20:30:41 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:23093) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tkm11-0003iu-Mg for 13207@debbugs.gnu.org; Mon, 17 Dec 2012 20:30:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLDj/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210134911" Original-Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 17 Dec 2012 20:29:21 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 34ADA58FA3; Mon, 17 Dec 2012 20:29:22 -0500 (EST) In-Reply-To: <8738z42vel.fsf@bernoul.li> (Jonas Bernoulli's message of "Mon, 17 Dec 2012 22:58:26 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68688 Archived-At: > Okay. On second though: it wouldn't be very useful to use the match > data set by these functions. Why not save the match-data here once so > that no caller has to ever worry about it? Is there a general policy > that this kinda thing shouldn't be done? Yes, the general policy is: all functions should be presumed to trash the match-data, except for a very few exceptions. > The 3500 packages from which I extracted metadata include all built-in > and fsf-elpa packages (though I did not process every library, just the > "main library" of each package). The three packages affected in a > negative way didn't do things right, and they aren't fsf packages. OK, thanks for checking. It sounds good then. Can you send a "final" patch? Stefan