unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#15332: Keystrokes's immediate echo only works every other time
@ 2013-09-11  2:26 Stefan Monnier
  2013-09-11  2:41 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2013-09-11  2:26 UTC (permalink / raw)
  To: 15332

Package: Emacs
Version: 24.3.50


If you do:

   C-u <wait> 5 5 5 5 ...

You'll see keystrokes echo as follows:

   C-u-          (correct)
   C-u 5         (instead of "C-u 5-")
   C-u 5 5-      (only appears after you wait echo-keystrokes seconds)
   C-u 5 5 5     (instead of "C-u 5 5 5-")
   C-u 5 5 5 5-  (only appears after you wait echo-keystrokes seconds)
   ...

This worked correctly in 22.3 but is broken at least since 23.4.
   

        Stefan





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#15332: Keystrokes's immediate echo only works every other time
  2013-09-11  2:26 bug#15332: Keystrokes's immediate echo only works every other time Stefan Monnier
@ 2013-09-11  2:41 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2013-09-11  2:41 UTC (permalink / raw)
  To: 15332-done

> You'll see keystrokes echo as follows:

>    C-u-          (correct)
>    C-u 5         (instead of "C-u 5-")
>    C-u 5 5-      (only appears after you wait echo-keystrokes seconds)
>    C-u 5 5 5     (instead of "C-u 5 5 5-")
>    C-u 5 5 5 5-  (only appears after you wait echo-keystrokes seconds)
>    ...

> This worked correctly in 22.3 but is broken at least since 23.4.
   
The patch below appears to fix it.


        Stefan


=== modified file 'src/keyboard.c'
--- src/keyboard.c	2013-09-09 12:15:45 +0000
+++ src/keyboard.c	2013-09-11 02:27:54 +0000
@@ -2596,9 +2596,7 @@
 
   if (/* There currently is something in the echo area.  */
       !NILP (echo_area_buffer[0])
-      && (/* And it's either not from echoing.  */
-	  !EQ (echo_area_buffer[0], echo_message_buffer)
-	  /* Or it's an echo from a different kboard.  */
+      && (/* It's an echo from a different kboard.  */
 	  || echo_kboard != current_kboard
 	  /* Or we explicitly allow overwriting whatever there is.  */
 	  || ok_to_echo_at_next_pause == NULL))






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-11  2:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11  2:26 bug#15332: Keystrokes's immediate echo only works every other time Stefan Monnier
2013-09-11  2:41 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).