From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16804: 24.3.50; [PATCH] fix with-silent-modifications Date: Tue, 18 Feb 2014 23:39:29 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1392784815 10171 80.91.229.3 (19 Feb 2014 04:40:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Feb 2014 04:40:15 +0000 (UTC) Cc: 16804@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 19 05:40:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WFyxJ-00077q-N5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Feb 2014 05:40:21 +0100 Original-Received: from localhost ([::1]:56352 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFyxJ-00035w-AY for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Feb 2014 23:40:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFyx8-000344-Dv for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2014 23:40:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFyx1-0002gO-3U for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2014 23:40:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFyx0-0002fb-WF for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2014 23:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WFyx0-0004Ay-0W for bug-gnu-emacs@gnu.org; Tue, 18 Feb 2014 23:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2014 04:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16804-submit@debbugs.gnu.org id=B16804.139278477916008 (code B ref 16804); Wed, 19 Feb 2014 04:40:01 +0000 Original-Received: (at 16804) by debbugs.gnu.org; 19 Feb 2014 04:39:39 +0000 Original-Received: from localhost ([127.0.0.1]:59312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WFywc-0004A7-Th for submit@debbugs.gnu.org; Tue, 18 Feb 2014 23:39:39 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:24378) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WFywZ-00049q-Ei for 16804@debbugs.gnu.org; Tue, 18 Feb 2014 23:39:36 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFLd/8D/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFLd/8D/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="48098622" Original-Received: from 75-119-255-3.dsl.teksavvy.com (HELO ceviche.home) ([75.119.255.3]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 18 Feb 2014 23:39:29 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3EA896608C; Tue, 18 Feb 2014 23:39:29 -0500 (EST) In-Reply-To: (Leo Liu's message of "Wed, 19 Feb 2014 08:34:15 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:85871 Archived-At: > I was confused by why an eldoc-documentation-function always gets a nil > buffer-file-name in a js file in js2-mode. It turns out js2 wraps its > parsing routine in with-silent-modifications, thus all timers triggered > while parsing gets the nil value for buffer-file-name. I vaguely understand what kind of problem you're talking about, but not precisely enough to guess what kinds of fixes might make sense. > Any comments on the following fix? Thanks. I think I'd rather add a new inhibit-, but it's hard to tell without knowing more of the problem at hand. Stefan