From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Date: Thu, 10 Jul 2014 12:43:46 -0400 Message-ID: References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1405010736 9803 80.91.229.3 (10 Jul 2014 16:45:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Jul 2014 16:45:36 +0000 (UTC) Cc: Andreas Schwab , 17839@debbugs.gnu.org, Sebastian Wiesner To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 10 18:45:28 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X5HTL-0003Yf-My for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Jul 2014 18:45:27 +0200 Original-Received: from localhost ([::1]:39039 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5HTL-0001ND-BS for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Jul 2014 12:45:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5HT8-0001Lo-9Z for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 12:45:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5HSx-0001Bl-Ag for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 12:45:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5HSx-0001Ai-7F for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 12:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X5HSw-0000SI-7U for bug-gnu-emacs@gnu.org; Thu, 10 Jul 2014 12:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jul 2014 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14050106431542 (code B ref 17839); Thu, 10 Jul 2014 16:45:02 +0000 Original-Received: (at 17839) by debbugs.gnu.org; 10 Jul 2014 16:44:03 +0000 Original-Received: from localhost ([127.0.0.1]:52395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5HRu-0000O8-R5 for submit@debbugs.gnu.org; Thu, 10 Jul 2014 12:44:03 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:59826) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5HRo-0000Nn-Pk for 17839@debbugs.gnu.org; Thu, 10 Jul 2014 12:43:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzAEEhQYDSSIBAjSGReOegcYhCAElB6Ue4FqgXGBWyE X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzAEEhQYDSSIBAjSGReOegcYhCAElB6Ue4FqgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="77080473" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Jul 2014 12:43:46 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id AFD37604AF; Thu, 10 Jul 2014 12:43:46 -0400 (EDT) In-Reply-To: <87fvi9jn5w.fsf@gmx.de> (Michael Albinus's message of "Thu, 10 Jul 2014 16:36:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91392 Archived-At: > Well, I've tried this 'cos I believe it is important. The idea is to > give the prompt in read-passwd the text property 'hide-chars. In > noninteractive mode, emacs writes "." instead of echoing the password > while typing. You can test it with I think a more idiomatic way to do that would be to use a global Lisp var that's let-bound in read-passwd. > + else if (hide_chars && (c == 127)) /* DEL */ > + { > + /* Unfortunately, we cannot edit stdout. */ > + // fprintf (stdout, "%c", c); > + /* Hmm, this doesn't work for multi-byte characters. */ > + (len > 0) && len--; > + } I don't think that's worth the trouble. Stefan