From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18861: Acknowledgement (25.0.50; gfile-based file notifications are not immediate) Date: Thu, 30 Oct 2014 12:12:40 -0400 Message-ID: References: <87zjchdokj.fsf@secretsauce.net> <87wq7kes7w.fsf@secretsauce.net> <87vbn3eup2.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1414781402 25199 80.91.229.3 (31 Oct 2014 18:50:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Oct 2014 18:50:02 +0000 (UTC) Cc: 18861@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 31 19:49:54 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XkHGk-0001F5-GV for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Oct 2014 19:49:54 +0100 Original-Received: from localhost ([::1]:41144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkHGk-0005oD-2j for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Oct 2014 14:49:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkEIX-0005wp-A0 for bug-gnu-emacs@gnu.org; Fri, 31 Oct 2014 11:40:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjsLO-00067k-BB for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 12:13:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjsLO-00067f-88 for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 12:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XjsLN-0006nT-Uy for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Oct 2014 16:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18861-submit@debbugs.gnu.org id=B18861.141468556326100 (code B ref 18861); Thu, 30 Oct 2014 16:13:01 +0000 Original-Received: (at 18861) by debbugs.gnu.org; 30 Oct 2014 16:12:43 +0000 Original-Received: from localhost ([127.0.0.1]:40690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XjsL5-0006mt-4e for submit@debbugs.gnu.org; Thu, 30 Oct 2014 12:12:43 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:48793) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XjsL2-0006mj-79 for 18861@debbugs.gnu.org; Thu, 30 Oct 2014 12:12:41 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s9UGCc5w025760; Thu, 30 Oct 2014 12:12:38 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 21567660F3; Thu, 30 Oct 2014 12:12:40 -0400 (EDT) In-Reply-To: <87vbn3eup2.fsf@secretsauce.net> (Dima Kogan's message of "Tue, 28 Oct 2014 14:30:17 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5110=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5110> : inlines <1461> : streams <1330528> : uri <1830466> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:95316 > Hi. A glib maintainer responded to the bug report, and it turns out > emacs was using glib slightly incorrectly. I'm attaching a patch to fix > the issue, as suggested by the maintainer. Thanks. This is not my area of expertise at all, but since it seems that noone else has replied yet, I'll try to move it along. > + if( g_main_context_acquire(context) != TRUE ) > + { > + // we couldn't acquire the context. I let this function proceed because it > + // handles more than just glib file descriptors > + retval = -1; > + } > + else > + context_acquired = true; [ Please follow our coding conventions: put a space before open parens (and not after, nor before close parens); use /*...*/ for comments; capitalize and punctuate comments; use two spaces between sentences. Also, I think "!g_main_context_acquire (context)" would be cleaner than "g_main_context_acquire (context) != TRUE". I find comparing to NULL, true, or false generally ugly, tho maybe that's just a personal taste of mine that others don't share. ] Why set retval to -1? It seems safer to leave it unchanged (ie. set to 0). Stefan