From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 24042@debbugs.gnu.org
Cc: Tassilo Horn <tsdh@gnu.org>
Subject: bug#24042: mudraw doesn't exist any more
Date: Wed, 20 Jul 2016 17:24:17 -0400 [thread overview]
Message-ID: <jwvtwfkvw8u.fsf@iro.umontreal.ca> (raw)
Package: Emacs
Version: 25.1.50
Apparently mudraw has been superseded by "mutool draw". I'm using the
patch below to accommodate this new situation, but it's not
quite satisfactory.
Stefan
diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index e16d453..d16b2f5 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -164,6 +164,8 @@ doc-view-ghostscript-program
(defcustom doc-view-pdfdraw-program
(cond
((executable-find "pdfdraw") "pdfdraw")
+ ((executable-find "mudraw") "mudraw")
+ ((executable-find "mutool") "mutool")
(t "mudraw"))
"Name of MuPDF's program to convert PDF files to PNG."
:type 'file
@@ -1028,7 +1030,10 @@ doc-view-djvu->tiff-converter-ddjvu
(defun doc-view-pdf->png-converter-mupdf (pdf png page callback)
(doc-view-start-process
"pdf->png" doc-view-pdfdraw-program
- `(,(concat "-o" png)
+ ;; FIXME: Ugly hack: recent mupdf distribution replaced "mudraw" with
+ ;; "mutool draw".
+ `(,@(if (string-match "mutool[^/\\]*$" doc-view-pdfdraw-program) '("draw"))
+ ,(concat "-o" png)
,(format "-r%d" (round doc-view-resolution))
,pdf
,@(if page `(,(format "%d" page))))
next reply other threads:[~2016-07-20 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 21:24 Stefan Monnier [this message]
2016-07-20 22:53 ` bug#24042: mudraw doesn't exist any more Nicolas Petton
2016-07-21 1:17 ` Stefan Monnier
2016-07-21 1:33 ` Mark Oteiza
2016-07-21 1:55 ` Mark Oteiza
2016-07-21 3:46 ` Clément Pit--Claudel
2020-09-04 13:16 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtwfkvw8u.fsf@iro.umontreal.ca \
--to=monnier@iro.umontreal.ca \
--cc=24042@debbugs.gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).