From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: Juri Linkov <juri@linkov.net>, 32607@debbugs.gnu.org
Subject: bug#32607: 27.0.50; pop-to-buffer in next-error-no-select
Date: Sun, 16 Sep 2018 17:19:24 -0400 [thread overview]
Message-ID: <jwvtvmp402v.fsf-monnier+Inbox@gnu.org> (raw)
In-Reply-To: <5B9E1DD4.8090802@gmx.at> (martin rudalics's message of "Sun, 16 Sep 2018 11:09:40 +0200")
>>> (save-selected-window
>>> (let ((next-error-highlight next-error-highlight-no-select)
>>> (display-buffer-overriding-action
>>> '(nil (inhibit-same-window . t))))
>>> (next-error n)))
>>
>> This is much simpler. Actually, this is what I wanted to propose as
>> a solution to Martin in one of previous messages, but I mistakenly wrote
>> save-window-excursion whereas I actually intended save-selected-window.
>
> I still do not understand whether we are sure that at the time the
> code above gets called 'next-error-last-buffer' is really shown in the
> selected window.
Indeed, I don't see any obvious indication that this is the case.
I suspect it's *usually* the case because next-error-no-select is only
bound to keys in "error buffers", but if you
M-x next-error-no-select
from a C file, I suspect that the buffer shown in the selected-window at
the beginning of the command won't be equal to the next-error-last-buffer.
I'm not sure what would be considered the *right* behavior in that case:
should the selected-window at the end display the same buffer as at the
beginning, or should it show the buffer that contains the error
(e.g. *grep* or *compilation*)?
My own take on it is that it's perfectly OK to have the final
selected-window show the buffer in which the command was typed (rather
than the *grep*/*compilation* buffer).
Stefan
prev parent reply other threads:[~2018-09-16 21:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 22:32 bug#32607: 27.0.50; pop-to-buffer in next-error-no-select Juri Linkov
2018-09-02 7:14 ` martin rudalics
2018-09-02 22:43 ` Juri Linkov
2018-09-03 7:31 ` martin rudalics
2018-09-03 22:31 ` Juri Linkov
2018-09-04 7:51 ` martin rudalics
2018-09-04 21:28 ` Juri Linkov
2018-09-05 7:47 ` martin rudalics
2018-09-05 22:06 ` Juri Linkov
2018-09-06 7:04 ` martin rudalics
2018-09-06 21:56 ` Juri Linkov
2018-09-07 6:28 ` Eli Zaretskii
2018-09-08 23:28 ` Juri Linkov
2018-09-09 5:44 ` Eli Zaretskii
2018-09-07 7:28 ` martin rudalics
2018-09-08 23:46 ` Juri Linkov
2018-09-09 8:40 ` martin rudalics
2018-09-09 16:01 ` Juri Linkov
2018-09-10 8:29 ` martin rudalics
2018-09-11 23:47 ` Juri Linkov
2018-09-12 6:33 ` martin rudalics
2018-09-12 21:47 ` Juri Linkov
2018-09-12 22:03 ` Stefan Monnier
2018-09-12 22:21 ` Juri Linkov
2018-09-12 22:06 ` Stefan Monnier
2018-09-13 7:46 ` martin rudalics
2018-09-13 11:26 ` Stefan Monnier
2018-09-13 23:04 ` Juri Linkov
2018-09-14 1:34 ` Stefan Monnier
2018-09-15 23:31 ` Juri Linkov
2018-09-16 9:09 ` martin rudalics
2018-09-16 21:19 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtvmp402v.fsf-monnier+Inbox@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=32607@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).