unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Fernando Jascovich <fernando.ej@gmail.com>, 33887@debbugs.gnu.org
Subject: bug#33887: 26.1; Emacs hangs for several seconds when going to the end of an XML file in nXML mode
Date: Thu, 17 Jan 2019 18:25:55 -0500	[thread overview]
Message-ID: <jwvtvi6eup3.fsf-monnier+bug#33887@gnu.org> (raw)
In-Reply-To: <8336q0im6k.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Jan 2019 17:09:39 +0200")

>> From: Fernando Jascovich <fernando.ej@gmail.com>
>> Date: Tue, 08 Jan 2019 19:11:02 -0300
>> 
>> Hi everyone, this is my first email to bug-gnu-emacs, so please let me
>> know if I am making some mistake.
>> For no special reason, I took this bug in order to start to know  emacs'
>> code.
>> Following and confirming the details of the bug, I found that indeed the
>> performance issue is introduced at commit 0055190174, but not beacuse
>> the introduction of `sgml-syntax-propertize-inside`.
>> The problem is with the last rule:
>> ```
>> ("\"" (0 (if (prog1 (zerop (car (syntax-ppss (match-beginning 0))))
>>                     (goto-char (match-end 0)))
>>                   (string-to-syntax ".")))
>> ```
>> I can't see the real effect of this rule, I tested xml parsing without
>> this rule and it works fine, marking double quotes inside tags as
>> expected without this performance issue.
>> Do we need to target double quotes outside tags explicitly?
>
> Stefan, any comments?

Yes, he's exactly right.

I just pushed a patch to master which should reduce significantly
this delay.


        Stefan





  reply	other threads:[~2019-01-17 23:25 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-27 10:13 bug#33887: 26.1; Emacs hangs for several seconds when going to the end of an XML file in nXML mode Vincent Lefevre
2018-12-27 16:02 ` Eli Zaretskii
2018-12-27 16:39   ` Stefan Monnier
2018-12-27 16:43     ` Eli Zaretskii
2018-12-27 17:32       ` Stefan Monnier
2018-12-27 17:47         ` Eli Zaretskii
2018-12-27 18:43         ` Vincent Lefevre
2018-12-28 17:18           ` Stefan Monnier
2019-01-17 22:57   ` Stefan Monnier
2019-01-08 22:11 ` Fernando Jascovich
2019-01-10 15:09   ` Eli Zaretskii
2019-01-17 23:25     ` Stefan Monnier [this message]
2019-05-15 23:53 ` Noam Postavsky
2019-05-16 10:54   ` Vincent Lefevre
2019-05-16 12:15   ` Noam Postavsky
2019-05-17 21:36     ` Vincent Lefevre
2019-05-18  4:15       ` Noam Postavsky
2019-05-18 14:47         ` Vincent Lefevre
2019-05-18 14:55           ` Vincent Lefevre
2019-05-18 14:57             ` Vincent Lefevre
2019-05-18 15:01               ` Vincent Lefevre
2019-05-18 18:49           ` Noam Postavsky
2019-05-19  0:17             ` Vincent Lefevre
2019-05-19 17:43               ` Noam Postavsky
2019-05-19 18:48                 ` Stefan Monnier
2019-05-19 19:03                   ` Noam Postavsky
2019-05-19 19:24                     ` Stefan Monnier
2019-05-20 20:47                       ` Noam Postavsky
2019-05-21  1:06                         ` Vincent Lefevre
2019-05-21 12:27                           ` Noam Postavsky
2019-05-22 13:58                             ` Stefan Monnier
2019-05-22 15:44                               ` Vincent Lefevre
2019-05-22 16:01                                 ` Stefan Monnier
2019-05-22 22:37                         ` Stefan Monnier
2019-05-26 22:17                           ` Noam Postavsky
2019-05-27  9:18                             ` Vincent Lefevre
2019-05-27 12:02                               ` Noam Postavsky
2019-05-29  0:30                                 ` Vincent Lefevre
2019-06-04 12:55                                   ` Noam Postavsky
2019-05-22 21:44                       ` Stefan Monnier
2019-05-20 11:47             ` Vincent Lefevre
2019-05-16 14:01   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwvtvi6eup3.fsf-monnier+bug#33887@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=33887@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=fernando.ej@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).