From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Pip Cet <pipcet@gmail.com>
Cc: 34757-done@debbugs.gnu.org, chuntaro <chuntaro@sakura-games.jp>
Subject: bug#34757: Invalid bytecode from byte compiler
Date: Sat, 27 Jul 2019 17:30:03 -0400 [thread overview]
Message-ID: <jwvtvb7maio.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAOqdjBcTM6Z5KYLeFj=wiX2DvB57wGn1uZL96Gqr=fGtXNAQ=A@mail.gmail.com> (Pip Cet's message of "Fri, 8 Mar 2019 21:13:37 +0000")
> We could fix byte-compile-out-toplevel to properly analyze how many
> stack arguments the call takes, but this patch simply treats forms
> like this as nontrivial:
>
> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> index 0b8f8824b4c..4e54e08ce14 100644
> --- a/lisp/emacs-lisp/bytecomp.el
> +++ b/lisp/emacs-lisp/bytecomp.el
> @@ -3025,6 +3025,7 @@ byte-compile-out-toplevel
> (or (null (cdr rest))
> (and (memq output-type '(file progn t))
> (cdr (cdr rest))
> + (eql (length body) (cdr (car rest)))
> (eq (car (nth 1 rest)) 'byte-discard)
> (progn (setq rest (cdr rest)) t))))
> (setq maycall nil) ; Only allow one real function call.
I installed this fix for now.
Stefan
prev parent reply other threads:[~2019-07-27 21:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 8:01 bug#34757: Invalid bytecode from byte compiler chuntaro
2019-03-08 13:18 ` Eli Zaretskii
2019-03-08 13:50 ` Michael Heerdegen
2019-03-08 14:36 ` Eli Zaretskii
2019-03-08 21:13 ` Pip Cet
2019-03-15 8:08 ` Eli Zaretskii
2019-03-15 14:08 ` Stefan Monnier
2019-03-15 19:40 ` Pip Cet
2019-03-15 20:30 ` Stefan Monnier
2019-03-16 16:51 ` Pip Cet
2019-06-13 11:44 ` Pip Cet
2019-07-27 21:30 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtvb7maio.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=34757-done@debbugs.gnu.org \
--cc=chuntaro@sakura-games.jp \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).