From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#26996: 25.1; doc-view-revert-buffer doesn't detect file change while using tramp Date: Fri, 01 Nov 2019 16:07:15 -0400 Message-ID: References: <87sgofl0me.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="154338"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Iakov Davydov , 26996@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 01 21:26:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQdUp-000e0P-1e for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Nov 2019 21:26:11 +0100 Original-Received: from localhost ([::1]:42680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQdUn-0006L7-60 for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Nov 2019 16:26:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44544) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQdUh-0006Kx-14 for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 16:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQdUf-0007rw-VF for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 16:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48490) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQdUf-0007rF-R7 for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 16:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQdUf-0005RM-Mz for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2019 16:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Nov 2019 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26996 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 26996-submit@debbugs.gnu.org id=B26996.157263991920820 (code B ref 26996); Fri, 01 Nov 2019 20:26:01 +0000 Original-Received: (at 26996) by debbugs.gnu.org; 1 Nov 2019 20:25:19 +0000 Original-Received: from localhost ([127.0.0.1]:57308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQdTy-0005Pk-O2 for submit@debbugs.gnu.org; Fri, 01 Nov 2019 16:25:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQdTx-0005PU-IL for 26996@debbugs.gnu.org; Fri, 01 Nov 2019 16:25:17 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C236E81231; Fri, 1 Nov 2019 16:25:11 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1E085806A2; Fri, 1 Nov 2019 16:25:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572639910; bh=ySA2fqUbV6ZoQ4mRrfCYKp2xwtHSIvh7rnyKvDKFoyw=; h=Resent-To:Resent-From:Resent-Date:From:To:Cc:Subject:References: Date:In-Reply-To:From; b=OJPXr3nuEJle6RzXfCxBOKnKreVK04PyyhQCrQwrOO6LLMtMB8budGVDBDjzeF6E8 h3pqxk6rSBcFugBB+5JAIoCh7uqNpJnIUo4Uzhw2ODVIb26PGkCUA6g7B21w1NM+v7 z1AifQ55vCjQvz0O54QqcAiM1diozgLIQ9Nb2ySNWvExPtpaiEHnXcuu7xMuhAmt5f ilSsVzbp+9ZZ1KKROI5ghCArSJgm4/hYHX4qNdApNFgAVoCvfdGPEaGG5AvNOV3YsJ 9CC2btS8lqA4s9W469aB/jFRy/diy9g3k3t6D20ZrQPHzROA7olcmhgH6h2atYh+B8 wKGIjbGCZV1iA== Original-Received: from pastel (unknown [45.72.255.86]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5163E1202A4; Fri, 1 Nov 2019 16:25:09 -0400 (EDT) Resent-Content-Type: text/x-markdown; charset=UTF-8 Resent-Message-ID: Resent-To: 26996@debbugs.gnu.org Resent-From: Stefan Monnier Resent-Date: Fri, 01 Nov 2019 16:25:06 -0400 Original-Received: from mail01.iro.umontreal.ca by mail01.iro.umontreal.ca with LMTP id sAXZNHeQvF3AcgAASs+2LQ for ; Fri, 01 Nov 2019 16:07:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca (pmg1.iro.umontreal.ca [172.31.2.40]) by mail01.iro.umontreal.ca (Postfix) with ESMTPS id 946E714024E for ; Fri, 1 Nov 2019 16:07:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572638839; bh=ySA2fqUbV6ZoQ4mRrfCYKp2xwtHSIvh7rnyKvDKFoyw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KqY2b5wMjCIwhfbo3KiUZ8iD7gl1vWqt7uMJMEqO2sPsKFLvVZ/xyY4bPq9V6zNBw MtfrRs+Tckdyd/8h7M/GFqvrxAqrEirHnDsdBbUmjtxbPEYD6fxu4GYroWnj0KH50F RWrjxBedWDCZ91sXfVZxBv3NgjCXxIsgR0B19KvWCH7XuNYB7Wh8rJP0YouhcY4f/J CmrP8JrKM+gOLbZsN0oYVYU3+few0z1xFuytQqzQn15rVFkoWIkoStkaK51HIK8q0H JH9TbcJWbqbMNJLzr3jmpq7G1QLc+inM5UXDedMfrZAq5e64cTIpX2eK6yUOFBYkyk Pt2AeCCJY/p1Q== Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6F95D10060F; Fri, 1 Nov 2019 16:07:19 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EE0C91004B3; Fri, 1 Nov 2019 16:07:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572638838; bh=ySA2fqUbV6ZoQ4mRrfCYKp2xwtHSIvh7rnyKvDKFoyw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=k2LGYliN3SATmXwzcSbGDWvb61fvOPnfDfifSXakjaG7pX3KEEHEvm3jDdlKVGmqA VMC4JFI+DSUM5aW8pvltZTl4xGxMoGdCnrXHyYAVuRPVMZaQn6ApsKGyDxZmp4n6vV zH5gbFGmeJ8LRO48m5bpMeIqcD1cJjl1H+/zYaaOJZRWqNQ42b8ShxA8oDr4ZZo5Fh 1uO7grSKLrpXjJ/6ujy9SSyEp2UBD4pHPxVngAbicfbfmXchlSJTarM1ddazFFnyM4 OAQ1MOsU0sRJo+f4leQ+xnTVk+TGmwv8lMHe05iFCPs2QC6ghiUZgM/NIRfu0TVAoS uoM3E1yH6O3UQ== Original-Received: from pastel (unknown [45.72.255.86]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B7D0B1206E3; Fri, 1 Nov 2019 16:07:17 -0400 (EDT) In-Reply-To: <87sgofl0me.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Sep 2019 14:59:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170676 Archived-At: >> I have problem with reverting buffer when opening pdf via tramp. >> This happens in emacs 24 and emacs 25, with different version of tramp. >> >> Steps to reproduce are like this: >> 1. Open pdf with tramp over ssh -> DocView mode. >> 2. Update the pdf somehow on the server. >> 3. Press 'g' to revert buffer (doc-view-revert-buffer) -> "yes". >> >> If the pdf was updated, I expect to see an updated pdf. Instead I see an >> old pdf. > > I managed to reproduce this in Emacs 27, and it should now be fixed. Hmm... but now auto-revert loops forever: updating the file -> triggers auto-revert -> your new code saves the buffer to the file -> triggers auto-revert -> ... I think the patch below is needed. But I wonder why you added: (doc-view-make-safe-dir doc-view-cache-directory) did it just seemed safer or have you found a concrete case that needed it? Stefan diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 5f9d4fcc2f..457e4325cf 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -457,9 +457,11 @@ doc-view--revert-buffer (apply orig-fun args) ;; Update the cached version of the pdf file, ;; too. This is the one that's used when - ;; rendering. - (doc-view-make-safe-dir doc-view-cache-directory) - (write-region nil nil doc-view--buffer-file-name)))) + ;; rendering (bug#26996). + (unless (equal buffer-file-name + doc-view--buffer-file-name) + (doc-view-make-safe-dir doc-view-cache-directory) + (write-region nil nil doc-view--buffer-file-name))))) (if (and (eq 'pdf doc-view-doc-type) (executable-find "pdfinfo")) ;; We don't want to revert if the PDF file is corrupted which