From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Date: Thu, 11 Mar 2021 17:54:00 -0500 Message-ID: References: <87y2f0fq8v.fsf@protesilaos.com> <87sg58tkg7.fsf@tcd.ie> <87h7lofe6b.fsf@protesilaos.com> <87mtvfpgf2.fsf@protesilaos.com> <878s6wqq40.fsf@tcd.ie> <874khk6t7d.fsf@protesilaos.com> <87mtvb1s3r.fsf@protesilaos.com> <871rcmojgc.fsf@protesilaos.com> <87lfau1tm3.fsf@tcd.ie> <87h7li9jtf.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20728"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 46964@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 11 23:55:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKUCz-0005Go-RD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Mar 2021 23:55:09 +0100 Original-Received: from localhost ([::1]:57340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKUCy-0007BI-Un for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Mar 2021 17:55:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKUCs-0007At-Jy for bug-gnu-emacs@gnu.org; Thu, 11 Mar 2021 17:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKUCs-0005Pr-CG for bug-gnu-emacs@gnu.org; Thu, 11 Mar 2021 17:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKUCs-0000fE-9k for bug-gnu-emacs@gnu.org; Thu, 11 Mar 2021 17:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Mar 2021 22:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46964-submit@debbugs.gnu.org id=B46964.16155032502490 (code B ref 46964); Thu, 11 Mar 2021 22:55:02 +0000 Original-Received: (at 46964) by debbugs.gnu.org; 11 Mar 2021 22:54:10 +0000 Original-Received: from localhost ([127.0.0.1]:55337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKUC2-0000e6-Gt for submit@debbugs.gnu.org; Thu, 11 Mar 2021 17:54:10 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKUC0-0000dt-KJ for 46964@debbugs.gnu.org; Thu, 11 Mar 2021 17:54:09 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DAAC0440C25; Thu, 11 Mar 2021 17:54:02 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A4D4F440B22; Thu, 11 Mar 2021 17:54:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615503241; bh=VSl/doFmVIukXu1GjBDmVUBEwLRdsIpWX7BpWnYH+M8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DZHvho2z0XrFaCNZmlmezyswePmyCURtqxBEXfeUHHoBhX+iJsLPWQtiZUMQTPlk+ JxuHT4TkvfzHI5nUg72gZkhAU4PI5rd5faovnMNZsm4ihdJxsDSrc1dKSK8iCvs+gR Vp3SyB5deCvyNve5BcSd5EufM4nuZT02/JsJF8ugB+ScJqpf4MP8pDMiAneWAxTCBa Ka+gEk66Kot+7tTaFR8c8q6XvIHkgLmODN7pmsqAhpa2ZT804qBlx7qgBqnEtWnKA/ cb2nRv+j5LsW0+QEnmSKdvEP0Zz+afZwGlVk44HUdeV3ZJvN6HMiainhigqa8aEp0Z hNRqlI1FXj7og== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6B0A6120314; Thu, 11 Mar 2021 17:54:01 -0500 (EST) In-Reply-To: <87h7li9jtf.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Thu, 11 Mar 2021 10:27:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202100 Archived-At: > At any rate, I do not know how to implement such in-place substitutes. > Can you please point me to the relevant documentation or some previous > case that I could study? Then I will try to produce a patch. Rather than point at some similar previous case, here's how I'd do it: Make a new commit to the the elpa.git branches `modus--theme` which basically gut the `modus--theme.el` files, replacing them with tiny files containing just the header (where `Package-Requires:` says `modus-themes`) plus some shenanigans to look for the directory holding the `modus-themes.el` file and load the matching `modus--theme.el` from it. And maybe emit a warning just before doing that (both to state that the package is obsolete and to warn the users about the redirect, so they might know where to start looking in case something goes wrong). Stefan