unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	27442@debbugs.gnu.org, Constantine Kharlamov <Hi-Angel@yandex.ru>
Subject: bug#27442: Un-obsolete x-clipboard-yank, or provide analogous functional
Date: Mon, 05 Jul 2021 10:46:12 -0400	[thread overview]
Message-ID: <jwvtul8ygd7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <877di4yhk8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 05 Jul 2021 16:13:43 +0200")

> (defun gui-selection-value ()
>   (let ((clip-text
>          (when select-enable-clipboard
>            (let ((text (gui--selection-value-internal 'CLIPBOARD)))
>              (if (string= text "") (setq text nil))
>
>              ;; Check the CLIPBOARD selection for 'newness', is it different
>              ;; from what we remembered them to be last time we did a
>              ;; cut/paste operation.
>              (prog1
>                  (unless (equal text gui--last-selected-text-clipboard)
>                    text)
>                (setq gui--last-selected-text-clipboard text)))))
>
> So, indeed, if you `M-x clipboard-yank', then kill some text in Emacs,
> you can't `M-x clipboard-yank' until you've clipboarded some other text,
> yanked it, and then clipboarded the original text again.
>
> Fixing this should be pretty trivial -- the following patch should do
> the trick, I think (although I haven't tested it).  But I'm not quite
> sure about the intended logic here, so I've added Stefan M to the CCs --
> perhaps he has some comments.

AFAIK this part of the clipboard interaction is one I just preserved
from earlier code when I did my "gui-selection" rework.
I "just preserved" it because I don't really understand how it's
intended to work, nor do I understand enough of the design constraints
to be able to come up with my own design of how it should work :-(

Your patch looks acceptable to me (it is also disappointing because
it doesn't really help understand how this thing is intended to work,
but it follows the same principles as the ones I followed).


        Stefan






  reply	other threads:[~2021-07-05 14:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 14:29 bug#27442: Un-obsolete x-clipboard-yank, or provide analogous functional Constantine Kharlamov
2017-06-21 19:10 ` Eli Zaretskii
2017-06-21 19:55   ` Constantine Kharlamov
2021-07-05 14:13     ` Lars Ingebrigtsen
2021-07-05 14:46       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-07-05 15:28         ` Lars Ingebrigtsen
2021-07-05 15:59           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-05 16:55           ` Eli Zaretskii
2021-07-05 20:11             ` Lars Ingebrigtsen
2021-07-05 20:24               ` Lars Ingebrigtsen
2021-07-06 11:21               ` Eli Zaretskii
2021-07-06 14:18                 ` Lars Ingebrigtsen
2021-07-06 15:45                   ` Eli Zaretskii
2021-07-06 16:20                     ` Lars Ingebrigtsen
2021-07-06 17:15                       ` Eli Zaretskii
2021-07-06 17:26                         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtul8ygd7.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=27442@debbugs.gnu.org \
    --cc=Hi-Angel@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).