From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Date: Thu, 17 Feb 2022 14:13:59 -0500 Message-ID: References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3090"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: martin rudalics , Lars Ingebrigtsen , Ergus , Drew Adams , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 17 20:15:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKmFL-0000Xq-7v for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 20:15:19 +0100 Original-Received: from localhost ([::1]:51094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKmFJ-0007Qn-OC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 14:15:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKmF4-0007QM-9k for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 14:15:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKmF3-0003LZ-Ur for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 14:15:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKmF3-000190-SB for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 14:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Feb 2022 19:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53910 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53910-submit@debbugs.gnu.org id=B53910.16451252514322 (code B ref 53910); Thu, 17 Feb 2022 19:15:01 +0000 Original-Received: (at 53910) by debbugs.gnu.org; 17 Feb 2022 19:14:11 +0000 Original-Received: from localhost ([127.0.0.1]:52705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKmEE-00017e-PA for submit@debbugs.gnu.org; Thu, 17 Feb 2022 14:14:10 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKmEC-00017P-NN for 53910@debbugs.gnu.org; Thu, 17 Feb 2022 14:14:09 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9FEFE806A3; Thu, 17 Feb 2022 14:14:02 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 40CA8802B7; Thu, 17 Feb 2022 14:14:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645125241; bh=nWDhLgrxJI+tn6vor4skpCw7A+HY5No26GEmqYbdn50=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cp+NYKypgfuvst/SLRgWPTEoi7bNrYDOvottxKEVJvvDA3dwGjOmFgTNbUSbjZGlE CFpVJMa9vdDKbm8GwOs5pBMMuU5O4pLzs3WnkDmFgWOBAwrCba5xTXte4iljNFVycZ /xQqMELS2nshB0gxe/bruDYm2nvvDrsY/i+mxXBCS7VExW20qC0JFucEVnk49XSWwT ff4cCIGJko0tTbajed2MGMq/QSr83lqGkrPmr5uGO+j4dBAwxV4JbhNEAJAzXiLeBc XBwWiNtX+wtnmC83gQO7bGfd+tlwlc9JEUyFsjNxHMe4/J/ZLYoGNJTfLQIJxA/Lne 2F4LfTDxn2udQ== Original-Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EE931120B33; Thu, 17 Feb 2022 14:14:00 -0500 (EST) In-Reply-To: <861r06vbos.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 13 Feb 2022 20:50:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227112 Archived-At: > --- a/lisp/mouse.el > +++ b/lisp/mouse.el > @@ -541,7 +541,9 @@ context-menu-ffap > > (defvar context-menu-entry > `(menu-item ,(purecopy "Context Menu") ,(make-sparse-keymap) > - :filter ,(lambda (_) (context-menu-map))) > + :filter ,(lambda (_) (unless help-buffer-under-preparation > + ;; No need to build menu to describe keys > + (context-menu-map)))) > "Menu item that creates the context menu and can be bound to a mouse key.") FWIW, I find this hideous. `mouse.el` should not depend on `help-*` variables. > While it's possible to use the 'window' argument in all functions used > in window-safely-shrinkable-p, tab-line functions use functions that > don't accept the 'window' argument, e.g. current-buffer, kill-buffer. `window-buffer` is the function that returns the "current" buffer of a window. As for `kill-buffer`, I'm not sure what window arg you'd like to use by I suspect (kill-buffer (window-buffer )) is what you're after. Stefan