From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter Date: Sat, 15 Oct 2022 19:31:20 -0400 Message-ID: References: <87r0zaxeox.fsf@tcd.ie> <874jw6xe9h.fsf@tcd.ie> <87wn906765.fsf@tcd.ie> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Thomas Fitzsimmons , 58531@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 16 01:32:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojqdZ-0008Dj-3S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 01:32:13 +0200 Original-Received: from localhost ([::1]:42330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojqdX-0006zO-PL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 19:32:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojqdO-0006zA-Ew for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 19:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojqdO-0002Eq-0G for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 19:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojqdN-00032t-O7 for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 19:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 23:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58531 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58531-submit@debbugs.gnu.org id=B58531.166587669011662 (code B ref 58531); Sat, 15 Oct 2022 23:32:01 +0000 Original-Received: (at 58531) by debbugs.gnu.org; 15 Oct 2022 23:31:30 +0000 Original-Received: from localhost ([127.0.0.1]:42783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojqcs-000322-1u for submit@debbugs.gnu.org; Sat, 15 Oct 2022 19:31:30 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojqcq-00031p-V7 for 58531@debbugs.gnu.org; Sat, 15 Oct 2022 19:31:29 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2F2C410013B; Sat, 15 Oct 2022 19:31:23 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C85381000F2; Sat, 15 Oct 2022 19:31:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665876681; bh=MK07ygqmuGGkV+HlkJv52uWtzC2lMKRYixGjn87aXdA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GwuxlFCIGZEt2PNFenESnVv0OQBuznZ4V4016go7SYYcdQbQE8cvtQHy+dRR+8nLJ Cnand9Q9gx2LuuR/UcxlFjeno/88CiD++LBHMpltlkF2Awn9xjRFwJPx2XYJe6Yn5s XUkcCQr2hypi3yuoNgOqW7FB9/gvL8LFCY+lEguhBXyM+Zu/Dkoh6s/EQMys3MU8Gn V0bJTvCTtUXh70DWNqCPnzIiMBUIfgP8cBpjaABxCMxmfRkjnU0ceErnqj2obEjbHE F8v1Ucmf3kQOW6atdW2gLg6iPA4WaTyM43Ll90xybzbvt269IMgdcg3XQ/codKbuDA DkNw49fxqMowQ== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8E86A120422; Sat, 15 Oct 2022 19:31:21 -0400 (EDT) In-Reply-To: <87wn906765.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 16 Oct 2022 01:41:54 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245588 Archived-At: >> Hmmm looks like we forgot to mark the `testfn` arg obsolete here with >> `advertised-calling-convention` like we did for `map-elt`. >> Could you fix that oversight in your patch while you're at it? > > Sure, but generic functions don't play well with > advertised-calling-convention: each subsequent cl-defmethod overwrites > the preceding symbol-function, so any existing entry in > advertised-signature-table is no longer found after that. Good point. Not a reason not to add an `advertised-calling-convention`, but indeed we should fix that. Could you make a bug report for that? Stefan