From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Sat, 12 Aug 2023 14:07:39 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12021"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65051@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 12 20:08:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUt2F-0002wN-MI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Aug 2023 20:08:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUt1w-0001ny-8I; Sat, 12 Aug 2023 14:08:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUt1u-0001nd-BR for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 14:08:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUt1u-0006Yo-3P for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 14:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUt1t-0004Aj-MG for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 14:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2023 18:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.169186367416024 (code B ref 65051); Sat, 12 Aug 2023 18:08:01 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 12 Aug 2023 18:07:54 +0000 Original-Received: from localhost ([127.0.0.1]:57286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUt1m-0004AN-2l for submit@debbugs.gnu.org; Sat, 12 Aug 2023 14:07:54 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUt1k-0004A7-CZ for 65051@debbugs.gnu.org; Sat, 12 Aug 2023 14:07:53 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 791C8441104; Sat, 12 Aug 2023 14:07:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1691863665; bh=/NBYAonVjPJxvsgGXgZAy8nAKB9ubQywyN8LicV8+sQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=U0JrUfYGa3uaLMx3i3bDGd5u76v1lzQkF1u4pkpULAgzDvCVlEr8Hutgs2Qdh5EhX xqgV2JE9vVAfc37gNLpMvCgz4Vcud53GwZLPbYsl3BegcXYzuDIgloH94tLhKi6Sc5 K+kOhrDJj3yEYHp16nKfSJKJwGc0js4n4IcsDUXw6SA2HJVRnRRbTcZgMlXT9zsbMG 4AAiBlu5Mf+YLxpQywfJcDjNECckNOL/lBbfKTA6SKzmqclv2VtJ+/ax0MMnTfWsck gjyU97S0jdhMwimFKaNSdx2i/r9XdtOR7eDEF/TiLYQ9CU/tBZcWkmZf4hOlOk/vqW fQtGJoUv300Sw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3E20A4410F3; Sat, 12 Aug 2023 14:07:45 -0400 (EDT) Original-Received: from pastel (69-165-141-248.dsl.teksavvy.com [69.165.141.248]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1CC121200D7; Sat, 12 Aug 2023 14:07:45 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Sat, 12 Aug 2023 10:41:24 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267323 Archived-At: > Streamline time decoding and conversion > > * src/lisp.h (lisp_h_BASE2_EQ, BASE2_EQ): New macros and functions. > * src/timefns.c (tzlookup, Fdecode_time): Use them. > (Ftime_convert): Convert to symbol once, instead of many times. <===== > > .. form, if a SWP, gets replaced by its bare symbol, so that the > following comparisons can be done by BASE_EQ rather than EQ. It's an > optimisation, though I can't really see why it's worthwhile. > > If you remove that SWP handling, as you are proposing, you'll need to > set these BASE_EQ's back to EQ's, too. I see, thanks. It's kind of odd, tho: it's the only function that does that, AFAICT. I also can't see why `time-convert` should accept SWPs in addition to bare symbols. In my book, it seems like passing it an SWP would be a mistake. Stefan