From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer Date: Tue, 16 Apr 2024 22:58:10 -0400 Message-ID: References: <87zfuc48d5.fsf@gmail.com> <86msqc9dsa.fsf@gnu.org> <874jcjeuac.fsf@gmail.com> <86edbnajfp.fsf@gnu.org> <87mspwcn0f.fsf_-_@gmail.com> <86v84kmeh0.fsf@gnu.org> <874jc2y2ky.fsf@gmail.com> <86sezmjxbc.fsf@gnu.org> <86a5lsiuo8.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36358"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70136@debbugs.gnu.org, arstoffel@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 17 04:59:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwvW1-0009Hd-2l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Apr 2024 04:59:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwvVb-0004tb-De; Tue, 16 Apr 2024 22:58:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwvVZ-0004rv-KO for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2024 22:58:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwvVZ-0002Z0-DB for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2024 22:58:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwvVl-0004xc-Jg for bug-gnu-emacs@gnu.org; Tue, 16 Apr 2024 22:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Apr 2024 02:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70136 X-GNU-PR-Package: emacs Original-Received: via spool by 70136-submit@debbugs.gnu.org id=B70136.171332271719012 (code B ref 70136); Wed, 17 Apr 2024 02:59:01 +0000 Original-Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 02:58:37 +0000 Original-Received: from localhost ([127.0.0.1]:45457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwvVL-0004wS-Vm for submit@debbugs.gnu.org; Tue, 16 Apr 2024 22:58:37 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwvVG-0004uy-9x for 70136@debbugs.gnu.org; Tue, 16 Apr 2024 22:58:33 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BF75F1000D6; Tue, 16 Apr 2024 22:58:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1713322690; bh=emy6bxkfgwF5nbdT3eozgDo5q/4R0Ir8FIwzNuOanPM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=haOQDedoKnqWfIp0qvb5Mk63EfsldC6bUbD7NmlaHZfPDhIvzBdb1qU39IbNu8Zwc WwE0THZbVxsvowQVTVbVppvi9ynu3FD0cJOYwPmToeb+alATXPhrVfK+QzOffxZJD0 PBUKu9MyrEUUdeS5gikJHMSVx8b04GN/sACSeHciq9n8GaESvcIu9WEd+jRBkrWSDS sqajM70oCAPCTZjEQdv0Yfy2ImeO1WJYneHjq8IbEMf8YwI23oQZ2Z/ixTtMQpgKKk szK3Ih4XRvtgGup+WYGmoxukof/wwKmfJv7ErCRxe7KwRtUKx9MRoiBwPbY4Vhqjmb IpQUizbVPsJkw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BEACB100044; Tue, 16 Apr 2024 22:58:10 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 97E9E1204C0; Tue, 16 Apr 2024 22:58:10 -0400 (EDT) In-Reply-To: <86a5lsiuo8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Apr 2024 05:34:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283468 Archived-At: >> FWIW, back in 2010 (commit 8117868f0ce6) when we added support for >> dir-locals to non-file buffers, we did it without even a config var to >> turn it off. > That's not the same. Also, we did quite a few things wrong regarding > backward compatibility over the years, and I don't want us to repeat > past mistakes. I can relate to that, but I can't remember bug reports (nor questions from confused users in other channels) when we made that change, so I don't see why we should consider that specific past choice to be a "past mistake". Also, I'm not seeing why "That's not the same". > Like I said: I'm okay with this change provided that it is opt-in. The problem with that is discovery. Should we add a message like "ignoring dir-locals. See obey-dir-local-variables-in-all-non-file-buffers"? And of course a related question is what kind of granularity to use for the "opt-in"? Will we add a new var every time we notice another (set of) buffers for which we should apply dir-local vars, or would it be OK to have a single variable? If it's OK to have a single var: why should this var not apply to diff-mode, log-edit-mode, ...? Or should this var contain a list of modes which allow it, so we can make it default to (diff-mode log-edit-mode ...)? And maybe also allow a t value? And since this var is needed only to avoid breaking backward compatibility, it would be desirable to have a plan to get rid of it in the longer term. Stefan