unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, 73307@debbugs.gnu.org,
	Paul Eggert <eggert@cs.ucla.edu>,
	wiz@gatalith.at
Subject: bug#73307: Fix ctype(3) usage
Date: Wed, 18 Sep 2024 11:18:21 -0400	[thread overview]
Message-ID: <jwvttedf0v4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86r09h9odm.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 18 Sep 2024 14:45:25 +0300")

> You are testing characters for whitespace syntax, which is AFAIU
> subject to buffer-local syntax tables.  Thus, a strange enough setting
> of buffer syntax could make this code return unexpected results.
>
> Stefan, am I right?

Yup.

> Why can't we use something closer to the original code, which doesn't
> depend on buffer-local customizations?

We could use the global/default syntax table?
[ Or rely on some of the unicode tables?  ]


        Stefan






  reply	other threads:[~2024-09-18 15:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 21:25 bug#73307: Fix ctype(3) usage Thomas Klausner
2024-09-17 11:52 ` Eli Zaretskii
2024-09-17 11:55   ` Thomas Klausner
2024-09-18  0:05   ` Paul Eggert
2024-09-18  2:13     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-18 11:45     ` Eli Zaretskii
2024-09-18 15:18       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-18 15:35       ` Paul Eggert
2024-09-18 16:11         ` Eli Zaretskii
2024-09-18 16:22           ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvttedf0v4.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=73307@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=wiz@gatalith.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).