bug#74828: ELPA release note summary strips one line

bug#74828: ELPA release note summary strips one line

[Arash Esbati]

Hi all,

ELPA sends a note when a new package version is released.  IIUC, the
"Summary" part in this note is gathered from the ";;; Commentary:"
section of the file where the version is bumped.

I have the impression that one line is left out when the "Summary" is
generated.  See for example:

https://lists.gnu.org/archive/html/auctex-devel/2024-06/msg00036.html
https://lists.gnu.org/archive/html/auctex-devel/2024-10/msg00003.html
https://lists.gnu.org/archive/html/auctex-devel/2024-12/msg00002.html

Best, Arash

bug#74828: ELPA release note summary strips one line

[Stefan Kangas]

Arash Esbati <arash@gnu.org> writes:

> Hi all,
>
> ELPA sends a note when a new package version is released.  IIUC, the
> "Summary" part in this note is gathered from the ";;; Commentary:"
> section of the file where the version is bumped.
>
> I have the impression that one line is left out when the "Summary" is
> generated.  See for example:
>
> https://lists.gnu.org/archive/html/auctex-devel/2024-06/msg00036.html
> https://lists.gnu.org/archive/html/auctex-devel/2024-10/msg00003.html
> https://lists.gnu.org/archive/html/auctex-devel/2024-12/msg00002.html
>
> Best, Arash

Philip, Stefan, any comments here?

bug#74828: ELPA release note summary strips one line

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> ELPA sends a note when a new package version is released.  IIUC, the
>> "Summary" part in this note is gathered from the ";;; Commentary:"
>> section of the file where the version is bumped.
>>
>> I have the impression that one line is left out when the "Summary" is
>> generated.  See for example:

Yup, sure enough.
I believe I have fixed it with the patch below.


        Stefan


diff --git a/elpa-admin.el b/elpa-admin.el
index 72ff400c4f..c291c04448 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1,6 +1,6 @@
 ;;; elpa-admin.el --- Auto-generate an Emacs Lisp package archive  -*- lexical-binding:t -*-
 
-;; Copyright (C) 2011-2024  Free Software Foundation, Inc
+;; Copyright (C) 2011-2025  Free Software Foundation, Inc
 
 ;; Author: Stefan Monnier <monnier@iro.umontreal.ca>
 
@@ -2652,12 +2652,16 @@ If WITH-CORE is non-nil, it means we manage :core packages as well."
             (insert (if (not readme)
                         "[Not provided 🙁]"
                       (elpaa--section-to-plain-text readme)))
+            ;; It's import to terminate lines properly so we can detect
+            ;; truncated lines below to throw away the leftovers.
+            (unless (bolp) (insert "\n"))
             ;; Keep a max of about 10 lines of full-length text.
             (delete-region (min (+ beg 800) (point)) (point))
             (let ((end (point)))
               (delete-region
                ;; Truncate at the end of the nearest paragraph.
                (or (re-search-backward "\n[ \t]*$" beg t)
+                   ;; Throw away leftovers from truncated lines.
                    (re-search-backward "\n" beg t)
                    (point))
                end))

bug#74828: ELPA release note summary strips one line

[Arash Esbati]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> ELPA sends a note when a new package version is released.  IIUC, the
>>> "Summary" part in this note is gathered from the ";;; Commentary:"
>>> section of the file where the version is bumped.
>>>
>>> I have the impression that one line is left out when the "Summary" is
>>> generated.  See for example:
>
> Yup, sure enough.
> I believe I have fixed it with the patch below.

Thanks for the change.  I trust your patch works, so I'm closing this
report.  I will have an eye on this with next AUCTeX release; I will
re-open the report if necessary.

Best, Arash

bug#74828: ELPA release note summary strips one line

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Hi Arash, and happy new year,

> Thanks for the change.  I trust your patch works, so I'm closing this
> report.  I will have an eye on this with next AUCTeX release; I will
> re-open the report if necessary.

And thanks for noticing the problem.


        Stefan