From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3303: delete-frame raises old (invisible) frame Date: Tue, 26 May 2009 15:37:12 -0400 Message-ID: References: <513F6DDF-F57F-4C8E-A2ED-C2163183BFF0@cmu.edu> <10D37A53-45B3-46C2-8F2B-C38534094A93@cmu.edu> Reply-To: Stefan Monnier , 3303@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1243367398 31214 80.91.229.12 (26 May 2009 19:49:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 May 2009 19:49:58 +0000 (UTC) Cc: 3303@emacsbugs.donarmstrong.com, Chong Yidong , Adrian Robert To: David Reitter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 26 21:49:54 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M92el-00039I-NQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 May 2009 21:49:52 +0200 Original-Received: from localhost ([127.0.0.1]:51816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M92el-0000AW-8e for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 May 2009 15:49:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M92eH-0008Dr-Lg for bug-gnu-emacs@gnu.org; Tue, 26 May 2009 15:49:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M92eC-000892-LY for bug-gnu-emacs@gnu.org; Tue, 26 May 2009 15:49:21 -0400 Original-Received: from [199.232.76.173] (port=41156 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M92eC-00088W-9B for bug-gnu-emacs@gnu.org; Tue, 26 May 2009 15:49:16 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38133) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M92eA-00051b-T5 for bug-gnu-emacs@gnu.org; Tue, 26 May 2009 15:49:15 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4QJnB7k026852; Tue, 26 May 2009 12:49:12 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n4QJj37L026248; Tue, 26 May 2009 12:45:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 26 May 2009 19:45:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3303 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3303-submit@emacsbugs.donarmstrong.com id=B3303.124336664325474 (code B ref 3303); Tue, 26 May 2009 19:45:03 +0000 Original-Received: (at 3303) by emacsbugs.donarmstrong.com; 26 May 2009 19:37:23 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4QJbHsO025469 for <3303@emacsbugs.donarmstrong.com>; Tue, 26 May 2009 12:37:19 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AokFAPfhG0rO+JxR/2dsb2JhbACBT8xshAsFhX2COw X-IronPort-AV: E=Sophos;i="4.41,253,1241409600"; d="scan'208";a="39137944" Original-Received: from 206-248-156-81.dsl.teksavvy.com (HELO pastel.home) ([206.248.156.81]) by ironport2-out.teksavvy.com with ESMTP; 26 May 2009 15:37:12 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 150DA84B6; Tue, 26 May 2009 15:37:12 -0400 (EDT) In-Reply-To: <10D37A53-45B3-46C2-8F2B-C38534094A93@cmu.edu> (David Reitter's message of "Tue, 26 May 2009 14:20:22 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 26 May 2009 15:49:21 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28201 Archived-At: >>> PS.: I agree with the proposed change to after-make-frame-functions (not >>> selecting the frame immediately), but this doesn't relate to the bug at >>> hand. Also, I don't know why the modeline isn't updated. >> Agreed, this is a separate problem. > OK, are you keeping track of it, should we file another bug report to do so? Please make another bug report for it. >>> frame.c: >>> Fraise_frame: do not make invisible frames visible (Stefan Monnier). >> This is not OK for 23.1. It might be good to try it for 23.2. >> Also I think your other changes should make it unnecessary for the >> problem we're trying to fix. > As above. I intend to install it myself for Emacs-23.2. No need for a bug report for that, I think. >>> drawRect: do not set visibility/iconified flags because drawRect may be >>> called by NSView even if the frame is hidden. >> Do you happen to know why/when NSView might be called even for a frame >> that's not visible? > Unfortunately not, but invisibility does not guarantee absence of drawRect > messages unless this is promised somewhere in the NS API. > I do think that my patch here is right, though, as other ports set > visibility in more obvious places. Yes, the patch looks OK, but I'd still like to know why drawRect gets called in such cases, as well as why the visibility settings were modified in that routine. > Perhaps we should make sure that we don't get a lot of drawRect calls for > totally obscured frames, which would possibly be a performance-eater. Indeed. Stefan