From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Date: Thu, 14 Apr 2011 22:11:06 -0300 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1302833257 15910 80.91.229.12 (15 Apr 2011 02:07:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 15 Apr 2011 02:07:37 +0000 (UTC) Cc: 8463@debbugs.gnu.org, Daniel Colascione To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 15 04:07:32 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QAYRY-0006O0-NJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Apr 2011 04:07:32 +0200 Original-Received: from localhost ([::1]:45757 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAYRY-0000Fj-8d for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Apr 2011 22:07:32 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:44422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAYRU-0000CN-Cu for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2011 22:07:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QAYRT-0006Mo-NF for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2011 22:07:28 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAYRT-0006Mf-FV for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2011 22:07:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QAYR3-0001Ef-Ra; Thu, 14 Apr 2011 22:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Apr 2011 02:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8463 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8463-submit@debbugs.gnu.org id=B8463.13028332164732 (code B ref 8463); Fri, 15 Apr 2011 02:07:01 +0000 Original-Received: (at 8463) by debbugs.gnu.org; 15 Apr 2011 02:06:56 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QAYQx-0001EH-Sj for submit@debbugs.gnu.org; Thu, 14 Apr 2011 22:06:56 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QAYQw-0001E4-94 for 8463@debbugs.gnu.org; Thu, 14 Apr 2011 22:06:54 -0400 Original-Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:45880 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QAYQq-0003zT-9Z; Thu, 14 Apr 2011 22:06:48 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1F2FF66396; Thu, 14 Apr 2011 23:06:44 -0300 (ART) In-Reply-To: (Leo's message of "Sun, 10 Apr 2011 16:14:53 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 14 Apr 2011 22:07:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45818 Archived-At: > @@ -761,7 +761,8 @@ > (let ((map (make-sparse-keymap))) > ;; We use this alternative name, so we can use \\[occur-mode-mouse-goto]. > (define-key map [mouse-2] 'occur-mode-mouse-goto) > - (define-key map "\C-c\C-c" 'occur-mode-goto-occurrence) > + (define-key map "\C-c\C-c" 'occur-edit-mode) > + (define-key map "\C-x\C-q" 'occur-edit-mode) > (define-key map "\C-m" 'occur-mode-goto-occurrence) > (define-key map "o" 'occur-mode-goto-occurrence-other-window) > (define-key map "\C-o" 'occur-mode-display-occurrence) I haven't had a chance to look much at the code, but while the functionality generally sounds good, the C-c C-c binding above doesn't look right to me. I think C-x C-q is sufficient and there's no need to introduce such an incompatibility (not with code but with users). Stefan