From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: sssslang <sssslang@gmail.com>
Cc: 9735-done@debbugs.gnu.org
Subject: bug#9735: win32 emacs cannot load doc string from files which has non-ascii characters in path
Date: Wed, 12 Oct 2011 15:08:12 -0400 [thread overview]
Message-ID: <jwvsjmyt7tx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <D2392C2E-5ED4-43C7-A527-DDECD08D7B4E@gmail.com> (sssslang@gmail.com's message of "Wed, 12 Oct 2011 20:09:52 +0800")
> I use emacs-23.2 and codepage936 on my Windows box. And the "xxxxx" in the
> error message should be the non-latin characters but is something like
> "\301\226" now. Except "cl" and "calendar", other elisp sources seems can be
> loaded without problem. I don't know what makes the difference, but the
> error maybe caused by incorrect path encoding. The attached patch works on
> my machine, but it didn't have enough test. Hopes somebody could improve it.
The patch is doing the right thing, thank you. I installed
a slightly different one to call ENCODE_FILE fewer times.
Stefan
> --- emacs-23.2/src/doc.c 2010-04-04 06:26:07.000000000 +0800
> +++ emacs-23.2/src/doc.c 2011-10-12 17:19:54.000000000 +0800
> @@ -142,17 +142,17 @@
> tem = Ffile_name_absolute_p (file);
> if (NILP (tem))
> {
> - minsize = SCHARS (Vdoc_directory);
> + minsize = SCHARS (ENCODE_FILE (Vdoc_directory));
> /* sizeof ("../etc/") == 8 */
> if (minsize < 8)
> minsize = 8;
> - name = (char *) alloca (minsize + SCHARS (file) + 8);
> - strcpy (name, SDATA (Vdoc_directory));
> - strcat (name, SDATA (file));
> + name = (char *) alloca (minsize + SCHARS (ENCODE_FILE (file)) + 8);
> + strcpy (name, SDATA (ENCODE_FILE (Vdoc_directory)));
> + strcat (name, SDATA (ENCODE_FILE (file)));
> }
> else
> {
> - name = (char *) SDATA (file);
> + name = (char *) SDATA (ENCODE_FILE(file));
> }
> fd = emacs_open (name, O_RDONLY, 0);
> @@ -164,7 +164,7 @@
> /* Preparing to dump; DOC file is probably not installed.
> So check in ../etc. */
> strcpy (name, "../etc/");
> - strcat (name, SDATA (file));
> + strcat (name, SDATA (ENCODE_FILE (file)));
> fd = emacs_open (name, O_RDONLY, 0);
> }
prev parent reply other threads:[~2011-10-12 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 12:09 bug#9735: win32 emacs cannot load doc string from files which has non-ascii characters in path sssslang
2011-10-12 16:28 ` Glenn Morris
2011-10-12 16:36 ` Eli Zaretskii
2011-10-12 19:08 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsjmyt7tx.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=9735-done@debbugs.gnu.org \
--cc=sssslang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).