From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el Date: Thu, 14 Jun 2012 21:46:00 -0400 Message-ID: References: <20120615.041527.616439723447762585.yamato@redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1339724775 503 80.91.229.3 (15 Jun 2012 01:46:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 15 Jun 2012 01:46:15 +0000 (UTC) Cc: 11711@debbugs.gnu.org, Stefan Merten To: Masatake YAMATO Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 15 03:46:12 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SfLc2-0000oU-Sl for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jun 2012 03:46:11 +0200 Original-Received: from localhost ([::1]:40155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfLc2-0005SB-PK for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2012 21:46:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfLbz-0005S5-RS for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 21:46:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfLby-0006P6-0l for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 21:46:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfLbx-0006Ow-T1 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 21:46:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SfLen-0004MH-JJ for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 21:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jun 2012 01:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11711 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11711-submit@debbugs.gnu.org id=B11711.133972493916745 (code B ref 11711); Fri, 15 Jun 2012 01:49:01 +0000 Original-Received: (at 11711) by debbugs.gnu.org; 15 Jun 2012 01:48:59 +0000 Original-Received: from localhost ([127.0.0.1]:43457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SfLel-0004M2-Ek for submit@debbugs.gnu.org; Thu, 14 Jun 2012 21:48:59 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:58984) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SfLek-0004Lt-F7 for 11711@debbugs.gnu.org; Thu, 14 Jun 2012 21:48:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09sr+aN/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kE4gJBboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="191457351" Original-Received: from 108-175-230-141.dsl.teksavvy.com (HELO pastel.home) ([108.175.230.141]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 14 Jun 2012 21:46:01 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 506D859726; Thu, 14 Jun 2012 21:46:00 -0400 (EDT) In-Reply-To: <20120615.041527.616439723447762585.yamato@redhat.com> (Masatake YAMATO's message of "Fri, 15 Jun 2012 04:15:27 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60991 Archived-At: > This is not a bug report. This is a request to merge a patch > to the offcial source tree. > 2012-06-13 Masatake YAMATO > * textmodes/rst.el (rst-mode, rst-imenu-index): Added > imenu and which-func support. I'll let the other Stefan decide what to do with it. It looks pretty good for me. Just a few nitpicks below: > + ;; Imenu > + (set (make-local-variable 'imenu-create-index-function) 'rst-imenu-index) > + > + ;; Which func > + (when (and (boundp 'which-func-modes) (listp which-func-modes)) > + (add-to-list 'which-func-modes 'rst-mode)) > + > ;; Font lock. Try to punctuate your comments. > +(defun rst-imenu-find-adornments-for-position (adornments p) > + "Find adornments cell for position P in ADORNMENTS" And do punctuate your docstring (C-u M-x checkdoc-current-buffer RET might help you catch such things). Stefan