From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Stefan Merten <smerten@oekonux.de>
Cc: 11711@debbugs.gnu.org
Subject: bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el
Date: Mon, 18 Jun 2012 15:25:11 -0400 [thread overview]
Message-ID: <jwvsjdso23s.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <6464.1340012644@theowa.merten-home.homelinux.org> (Stefan Merten's message of "Mon, 18 Jun 2012 11:44:04 +0200")
>> + ;; Which func
>> + (when (and (boundp 'which-func-modes) (listp which-func-modes))
>> + (add-to-list 'which-func-modes 'rst-mode))
> This form changes the customizable variable `which-func-modes'. I
> thought this is not a good idea. I thought customizable variables
> should be changed by users alone.
Indeed, better not do it. The default in 24.2 is to allow all modes, so
this code is not used in that case anyway.
> However, in this case it seems useful.
Better let the user make the change.
Stefan
next prev parent reply other threads:[~2012-06-18 19:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 19:15 bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el Masatake YAMATO
2012-06-15 1:46 ` Stefan Monnier
2012-06-16 22:33 ` Masatake YAMATO
2012-06-18 1:59 ` Stefan Monnier
2012-06-18 9:28 ` Stefan Merten
2012-06-18 9:44 ` Stefan Merten
2012-06-18 19:25 ` Stefan Monnier [this message]
2012-06-18 9:57 ` Stefan Merten
2012-06-19 3:33 ` Masatake YAMATO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsjdso23s.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11711@debbugs.gnu.org \
--cc=smerten@oekonux.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).