From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.bugs Subject: bug#16818: Acknowledgement (Undo in region after markers in undo history relocated) Date: Wed, 19 Mar 2014 14:52:40 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1395255238 17446 80.91.229.3 (19 Mar 2014 18:53:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Mar 2014 18:53:58 +0000 (UTC) Cc: 16818@debbugs.gnu.org To: Barry OReilly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 19 19:54:06 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQLcp-0006iE-H6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Mar 2014 19:54:03 +0100 Original-Received: from localhost ([::1]:43278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQLcp-0008T5-5f for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Mar 2014 14:54:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQLby-00076N-E6 for bug-gnu-emacs@gnu.org; Wed, 19 Mar 2014 14:53:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQLbr-00023F-3l for bug-gnu-emacs@gnu.org; Wed, 19 Mar 2014 14:53:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQLbr-00022o-0j for bug-gnu-emacs@gnu.org; Wed, 19 Mar 2014 14:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WQLbq-0005AY-LZ for bug-gnu-emacs@gnu.org; Wed, 19 Mar 2014 14:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Mar 2014 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16818 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16818-submit@debbugs.gnu.org id=B16818.139525516419830 (code B ref 16818); Wed, 19 Mar 2014 18:53:02 +0000 Original-Received: (at 16818) by debbugs.gnu.org; 19 Mar 2014 18:52:44 +0000 Original-Received: from localhost ([127.0.0.1]:41550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQLbX-00059l-Lg for submit@debbugs.gnu.org; Wed, 19 Mar 2014 14:52:44 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:40168) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQLbV-00059d-G0 for 16818@debbugs.gnu.org; Wed, 19 Mar 2014 14:52:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgbBLY0Ng30DjhiWYoFegxOBSg X-IPAS-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAs0EhQYDSSIHgbBLY0Ng30DjhiWYoFegxOBSg X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52639784" Original-Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Mar 2014 14:52:40 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id AE0FB60123; Wed, 19 Mar 2014 14:52:40 -0400 (EDT) In-Reply-To: (Barry OReilly's message of "Wed, 19 Mar 2014 09:36:17 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86988 Archived-At: >> I'd have the same comment here, but if we emit a warning for sole >> marker-adjustments in the "non-region" code, we don't really have to >> worry about them here. > If you're saying changes under undo-make-selective-list are not > necessary, remember that currently it can create a list like: No, I mean that it's OK to *assume* that any marker-adjustment we find in the undo-region code is "right after a deletion". Of course, that's only relevant if that can help us simplify the code. >> I think we should only change the entry corresponding to a deletion >> such that it directly handles all the immediately following >> marker-adjustments > They don't always immediately follow. An integer record can be between > them. For example, at the end of the undo-test-marker-adjustment-moved > test I posted previously, buffer-undo-list is: > (nil (1 . 4) nil (abc . 1) 12 (# . -1) nil > (1 . 12) (t . 0)) Right, the integer record is indeed also added by the deletion, so we should still consider the marker adjustments to "immediately follow". > * Implement your proposal but skip over the (t ...) and integer > records > * Restructure the C code so as marker adjustments are always > immediately before deletion records > * Revisit the approach of fixing markers that move to unrelated > locations. I think the first option is best (hopefully, the set of "things that can come between the deletion and the marker adjustments" won't keep growing). Stefan