unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Simen Heggestøyl" <simenheg@gmail.com>
Cc: 20107@debbugs.gnu.org
Subject: bug#20107: [PATCH 3/3] css-mode: Update CSS property list
Date: Sat, 14 Mar 2015 10:05:25 -0400	[thread overview]
Message-ID: <jwvsid7of1w.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <1426332155.18090.2@smtp.gmail.com> ("Simen Heggestøyl"'s message of "Sat, 14 Mar 2015 12:22:35 +0100")

> There was code for extracting these properties automatically, but it
> produced an incorrect property list for CSS2,

This code was written long ago, and these kinds of things often need to
be tweaked for new versions of the file.

> and it didn't include any CSS3 modules.

Obviously ;-)

> I found it more convenient to compile the list manually, and I can
> volunteer to keep this list updated.  If it is desirable still to keep
> the automatic extraction code, I can look into fixing that as well.

As long as the source document lends itself to it, I like to have actual
code to extract the data (I find it easier to write (and tweak next time
around) the code than to do the extraction manually).

But if you're volunteering to be css-mode's maintainer, it's your call.

Other than that all 3 patches look good, feel free to install them.


        Stefan





  reply	other threads:[~2015-03-14 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-14 11:19 bug#20107: [PATCH 1/3] css-mode: Discriminate between pseudo-classes and -elements Simen Heggestøyl
2015-03-14 11:21 ` bug#20107: [PATCH 2/3] css-mode: Add support for completion in `css-mode' Simen Heggestøyl
2015-03-14 11:22 ` bug#20107: [PATCH 3/3] css-mode: Update CSS property list Simen Heggestøyl
2015-03-14 14:05   ` Stefan Monnier [this message]
2015-03-15 12:46     ` Simen Heggestøyl
2015-03-18 17:41   ` Simen Heggestøyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsid7of1w.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=20107@debbugs.gnu.org \
    --cc=simenheg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).