From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20365: 24.5; all-completions returns duplicates for Info-read-node-name-1 Date: Sat, 18 Apr 2015 22:04:54 -0400 Message-ID: References: <87egnhfmcd.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429409124 21546 80.91.229.3 (19 Apr 2015 02:05:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 19 Apr 2015 02:05:24 +0000 (UTC) Cc: 20365@debbugs.gnu.org To: Oleh Krehel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 19 04:05:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yjebf-0003mq-8I for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Apr 2015 04:05:11 +0200 Original-Received: from localhost ([::1]:47322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yjebe-0006yi-9A for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2015 22:05:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yjebb-0006wv-DE for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 22:05:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjebW-0007iI-D0 for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 22:05:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjebW-0007iA-9K for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 22:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YjebV-0002RC-Ul for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 22:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Apr 2015 02:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20365-submit@debbugs.gnu.org id=B20365.14294090999359 (code B ref 20365); Sun, 19 Apr 2015 02:05:01 +0000 Original-Received: (at 20365) by debbugs.gnu.org; 19 Apr 2015 02:04:59 +0000 Original-Received: from localhost ([127.0.0.1]:60323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjebS-0002Qt-Va for submit@debbugs.gnu.org; Sat, 18 Apr 2015 22:04:59 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34291) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjebQ-0002Qk-HY for 20365@debbugs.gnu.org; Sat, 18 Apr 2015 22:04:57 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3J24sBU028811; Sat, 18 Apr 2015 22:04:55 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B48BE2488; Sat, 18 Apr 2015 22:04:54 -0400 (EDT) In-Reply-To: (Oleh Krehel's message of "Sat, 18 Apr 2015 19:49:44 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5280=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5280> : inlines <2752> : streams <1424815> : uri <1910248> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101702 Archived-At: > What I think is happening there is that Info calls > `completing-read-function' and ultimately gives it (through > all-completions) a list like '("org" "emacs"...). And then it expects > the answer to be in the form "(org)" or "(emacs)". Which I think is > strange. IIUC the problem is as follows: the completion-table used by "g" in Info-mode lets you complete node names in the current file or lets you complete file names (which are placed within parens), but the completion table itself does not add those parens [ A long standing missing feature here is that it doesn't know how to complete a node name after the "()", even though it's a very much valid input to provide. ] Your ivy-mode generally wants to have a list of strings as candidates and wants those strings to be valid return values, whereas the way completion tables are defined there is no guarantee that you can get that kind of info from the completion table. We could change the Info-mode completion table so as to include the closing paren in the output of `all-completions' (and probably include the opening paren as well, in that case). Note also that on my system "g (ema TAB" includes things like "emacs23/" where "(emacs23/)" is not a valid element (since emacs-23 is a directorym which is complete in steps, just as in C-x C-f). Stefan