From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23906: 25.0.95; Undo boundary after process output is not consistent Date: Mon, 18 Jul 2016 20:41:17 -0400 Message-ID: References: <83r3b6lih2.fsf@gnu.org> <87h9bw5rfd.fsf@russet.org.uk> <87eg70i8k5.fsf@metalevel.at> <87d1mikef5.fsf@russet.org.uk> <874m7usn1m.fsf@metalevel.at> <8760sao9im.fsf@metalevel.at> <87mvllyypo.fsf@russet.org.uk> <87zipkzkge.fsf@metalevel.at> <87shvcfiox.fsf@russet.org.uk> <87shvccl2h.fsf@metalevel.at> <877fci93bh.fsf@metalevel.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468888953 8599 80.91.229.3 (19 Jul 2016 00:42:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2016 00:42:33 +0000 (UTC) Cc: Phillip Lord , 23906@debbugs.gnu.org To: Markus Triska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 02:42:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPJ73-0006oq-EZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 02:42:17 +0200 Original-Received: from localhost ([::1]:51241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPJ6y-0004uD-Vg for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 20:42:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPJ6t-0004tw-L0 for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 20:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPJ6o-00032X-Q8 for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 20:42:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPJ6o-00032T-MQ for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 20:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPJ6o-0000rC-BG for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 20:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2016 00:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23906 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23906-submit@debbugs.gnu.org id=B23906.14688888863246 (code B ref 23906); Tue, 19 Jul 2016 00:42:02 +0000 Original-Received: (at 23906) by debbugs.gnu.org; 19 Jul 2016 00:41:26 +0000 Original-Received: from localhost ([127.0.0.1]:56111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPJ6E-0000qI-46 for submit@debbugs.gnu.org; Mon, 18 Jul 2016 20:41:26 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:33257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPJ6D-0000q2-0C for 23906@debbugs.gnu.org; Mon, 18 Jul 2016 20:41:25 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A6FgA731xV/3mcpUVcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kiDcIzyMBAQEBAQUBAQEBHos6hQUHhC0BBLM/gUUjgWaCLiKCeAEBAQ X-IPAS-Result: A0A6FgA731xV/3mcpUVcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kiDcIzyMBAQEBAQUBAQEBHos6hQUHhC0BBLM/gUUjgWaCLiKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="248456084" Original-Received: from 69-165-156-121.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Jul 2016 20:41:18 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id EE254AE2BB; Mon, 18 Jul 2016 20:41:17 -0400 (EDT) In-Reply-To: <877fci93bh.fsf@metalevel.at> (Markus Triska's message of "Mon, 18 Jul 2016 21:03:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121246 Archived-At: > together in a pure way: It's OK if the handle is simply *not* used. Indeed, it's perfectly OK. > And a question: Is there any reason not to write viper-adjust-undo as: > (defun viper-adjust-undo () > (when viper--undo-change-group-handle > (undo-amalgamate-change-group viper--undo-change-group-handle) > (setq viper--undo-change-group-handle nil))) No really strong reason, no, but it just seems safer to set viper--undo-change-group-handle to nil before we start with undo-amalgamate-change-group, in case it signals an error. Stefan