From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23999: 25.0.95; Emacs hangs in rectangle-mark-mode with numeric prefix argument to `C-f' Date: Fri, 22 Jul 2016 10:17:50 -0400 Message-ID: References: <87twfq1qtr.fsf@moondust.awandering> <87y4517udy.fsf@gmx.net> <878twucg1z.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469197105 3334 80.91.229.3 (22 Jul 2016 14:18:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jul 2016 14:18:25 +0000 (UTC) Cc: jwiegley@gmail.com, 23999@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 22 16:18:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQbHJ-0005QU-Ho for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jul 2016 16:18:13 +0200 Original-Received: from localhost ([::1]:47453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQbHI-000127-Qd for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jul 2016 10:18:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQbHD-00011y-4f for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 10:18:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQbH8-0002CO-Sp for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 10:18:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQbH8-0002CH-PP for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 10:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQbH8-0004x2-Ft for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 10:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jul 2016 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23999 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23999-submit@debbugs.gnu.org id=B23999.146919707919022 (code B ref 23999); Fri, 22 Jul 2016 14:18:02 +0000 Original-Received: (at 23999) by debbugs.gnu.org; 22 Jul 2016 14:17:59 +0000 Original-Received: from localhost ([127.0.0.1]:33848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQbH4-0004wk-St for submit@debbugs.gnu.org; Fri, 22 Jul 2016 10:17:59 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:55763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQbH2-0004wW-FZ for 23999@debbugs.gnu.org; Fri, 22 Jul 2016 10:17:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CXDQA731xV/3mcpUVcgxCEAsEVhH6CTQQCAoE8OxIBAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQUBAQEBHos6hQUHhC0BBLM/gUUjgWZVgVkigngBAQE X-IPAS-Result: A0CXDQA731xV/3mcpUVcgxCEAsEVhH6CTQQCAoE8OxIBAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQUBAQEBHos6hQUHhC0BBLM/gUUjgWZVgVkigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="248879636" Original-Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 22 Jul 2016 10:17:50 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8BE5F64CAC; Fri, 22 Jul 2016 10:17:50 -0400 (EDT) In-Reply-To: <878twucg1z.fsf@gmx.net> (Stephen Berman's message of "Fri, 22 Jul 2016 09:01:12 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121417 Archived-At: >> @@ -644,7 +644,7 @@ rectangle--*-char >> (curcol (current-column)) >> (nextcol >> (condition-case nil >> - (save-excursion >> + (progn >> (funcall cmd 1) >> (cond >> ((> bol (point)) (- curcol 1)) Hmm... this function is quite messy. Using `progn' here make it even more messy (e.g. what happens when you jump over some TAB among the N movements). My impression is that the whole `save-excursion' thingy should be moved out of the while loop. And actually there probably shouldn't be any such loop at all: we should just do +n or -n directly. Stefan