From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: jwiegley@gmail.com, 23999@debbugs.gnu.org
Subject: bug#23999: 25.0.95; Emacs hangs in rectangle-mark-mode with numeric prefix argument to `C-f'
Date: Fri, 22 Jul 2016 10:17:50 -0400 [thread overview]
Message-ID: <jwvshv193gf.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <878twucg1z.fsf@gmx.net> (Stephen Berman's message of "Fri, 22 Jul 2016 09:01:12 +0200")
>> @@ -644,7 +644,7 @@ rectangle--*-char
>> (curcol (current-column))
>> (nextcol
>> (condition-case nil
>> - (save-excursion
>> + (progn
>> (funcall cmd 1)
>> (cond
>> ((> bol (point)) (- curcol 1))
Hmm... this function is quite messy. Using `progn' here make it even
more messy (e.g. what happens when you jump over some TAB among the
N movements).
My impression is that the whole `save-excursion' thingy should be moved
out of the while loop. And actually there probably shouldn't be any
such loop at all: we should just do +n or -n directly.
Stefan
next prev parent reply other threads:[~2016-07-22 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 22:25 bug#23999: 25.0.95; Emacs hangs in rectangle-mark-mode with numeric prefix argument to `C-f' N. Jackson
2016-07-16 10:24 ` Stephen Berman
2016-07-22 7:01 ` Stephen Berman
2016-07-22 7:14 ` Eli Zaretskii
2016-07-22 7:25 ` Stephen Berman
2016-07-22 9:31 ` Eli Zaretskii
2016-07-22 11:19 ` Stephen Berman
2016-07-22 11:21 ` Stephen Berman
2016-07-22 13:27 ` Eli Zaretskii
2016-07-22 14:17 ` Stefan Monnier [this message]
2016-07-20 17:19 ` Kaushal Modi
2016-07-22 23:25 ` Kaushal Modi
2016-07-23 7:35 ` Eli Zaretskii
2017-12-19 19:44 ` Charles A. Roelli
2017-12-19 21:55 ` N. Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvshv193gf.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=23999@debbugs.gnu.org \
--cc=jwiegley@gmail.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).