From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq Date: Thu, 28 Mar 2019 18:11:23 -0400 Message-ID: References: <95f744d5-426d-1ce1-15fa-9c49aaf6f2f0@cs.ucla.edu> <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="269044"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Paul Eggert , 34781@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 28 23:22:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9dPT-0017nQ-5e for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Mar 2019 23:22:07 +0100 Original-Received: from localhost ([127.0.0.1]:42650 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9dPS-0002b3-4W for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Mar 2019 18:22:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9dPD-0002Kc-Ix for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 18:21:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9dFi-0000c8-GQ for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 18:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49551) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9dFi-0000bu-9s for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 18:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h9dFi-0000D0-4Z for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 18:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Mar 2019 22:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34781-submit@debbugs.gnu.org id=B34781.1553811107772 (code B ref 34781); Thu, 28 Mar 2019 22:12:02 +0000 Original-Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 22:11:47 +0000 Original-Received: from localhost ([127.0.0.1]:34860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dFT-0000CO-3c for submit@debbugs.gnu.org; Thu, 28 Mar 2019 18:11:47 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:50715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9dFQ-0000C7-IZ for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 18:11:46 -0400 Original-Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x2SMBNDP016177; Thu, 28 Mar 2019 18:11:23 -0400 Original-Received: by lechazo.home (Postfix, from userid 20848) id 3783C63E74; Thu, 28 Mar 2019 18:11:23 -0400 (EDT) In-Reply-To: <3a02a3378a526c8706b33f36b85c003a82aa2aa1.camel@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Thu, 28 Mar 2019 22:51:39 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6513=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6513> : inlines <7045> : streams <1817053> : uri <2821538> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156905 Archived-At: > (let ((upat (cddr alt))) > (eq (car-safe upat) 'quote))) > (let ((val (cadr (cddr alt)))) > - (unless (or (integerp val) (symbolp val)) > + (unless (or (portable-fixnum-p val) (symbolp val)) > (setq memq-ok nil)) > (push (cadr (cddr alt)) simples)) > (push alt others)))) Really? I think the better option is below (since I think we should generally move away from `eq` and replace it with `eql`). Actually, the hunk below should have been installed at the same time I replaced `eq` with `eql` when testing against an integer. It was a mere oversight. Stefan diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el index 9de240154..d9a20b1ff 100644 --- a/lisp/emacs-lisp/pcase.el +++ b/lisp/emacs-lisp/pcase.el @@ -802,7 +802,7 @@ pcase--u1 ((> (length simples) 1) (pcase--u1 (cons `(match ,var . (pred (pcase--flip - ,(if memq-ok #'memq #'member) + ,(if memq-ok #'memql #'member) ',simples))) (cdr matches)) code vars