From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#35351: 27.0.50; Enable derived modes to run their own very-early 'change-major-mode-hook' code Date: Mon, 22 Apr 2019 22:08:58 -0400 Message-ID: References: <85237c18-768d-089b-221a-fe70b0ba4379@orcon.net.nz> <7db75b50-1925-8c1e-acc5-c393b701e6a3@orcon.net.nz> <3a0b9268-4800-1513-8422-065a74bb6b36@orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="24196"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35351@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 04:10:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIkss-000682-Hk for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 04:10:10 +0200 Original-Received: from localhost ([127.0.0.1]:46816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIksr-0004Y4-HM for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 22:10:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIksl-0004Xn-3D for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 22:10:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIksk-0007lQ-71 for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 22:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIksk-0007lI-40 for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 22:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIksj-00010z-Re for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 22:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2019 02:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35351 X-GNU-PR-Package: emacs Original-Received: via spool by 35351-submit@debbugs.gnu.org id=B35351.15559853433816 (code B ref 35351); Tue, 23 Apr 2019 02:10:01 +0000 Original-Received: (at 35351) by debbugs.gnu.org; 23 Apr 2019 02:09:03 +0000 Original-Received: from localhost ([127.0.0.1]:52043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIkrm-0000zT-MI for submit@debbugs.gnu.org; Mon, 22 Apr 2019 22:09:03 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:52360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIkrk-0000z2-Li for 35351@debbugs.gnu.org; Mon, 22 Apr 2019 22:09:01 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3N28wmw019687; Mon, 22 Apr 2019 22:08:59 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4508F66184; Mon, 22 Apr 2019 22:08:58 -0400 (EDT) In-Reply-To: <3a0b9268-4800-1513-8422-065a74bb6b36@orcon.net.nz> (Phil Sainty's message of "Tue, 23 Apr 2019 11:18:31 +1200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6530=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6530> : inlines <7058> : streams <1819452> : uri <2835931> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158094 Archived-At: >> Oh, you're absolutely right, it's called ":after-hook" because it >> runs after the mode-hook. > Which means :before-hook definitely isn't a good name for the new > keyword. It's run before the before-change-mode-hook, so the name isn't completely wrong (and the description of :before-hook makes this connection clear). > Should I go with :eval-before ? I'd prefer we avoid "eval" since that would suggest to quote the form. IOW, I think `:before-hook` is fine. Stefan