From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Federico Tedin <federicotedin@gmail.com>
Cc: 39291@debbugs.gnu.org, pogonyshev@gmail.com,
Juri Linkov <juri@linkov.net>
Subject: bug#39291: M-: history doesn't store erroneous input
Date: Thu, 30 Jan 2020 09:23:11 -0500 [thread overview]
Message-ID: <jwvsgjxdnyd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87blqm0x0f.fsf@gmail.com> (Federico Tedin's message of "Wed, 29 Jan 2020 22:32:16 +0100")
> My only doubt is that now, the call to `string_to_object' (which calls
> `read-from-string', which calls `read1', and then `read0') is located
> outside the context (not sure what the right term is) set up with
> `specbind'. Could this be a problem? Do any of these functions depend on
> the context set up in `read_minibuf'? (They don't appear to, just want
> to be sure).
AFAIK they don't depend on Lisp variables, no, so it should be safe to
move the call to `string_to_object` to after the `unbind_to`.
Stefan
next prev parent reply other threads:[~2020-01-30 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 15:16 bug#39291: M-: history doesn't store erroneous input Paul Pogonyshev
2020-01-28 23:35 ` Juri Linkov
2020-01-29 17:16 ` Eli Zaretskii
2020-01-29 18:09 ` Federico Tedin
2020-01-29 21:32 ` Federico Tedin
2020-01-30 14:14 ` Eli Zaretskii
2020-01-30 14:20 ` Stefan Monnier
2020-01-30 14:23 ` Stefan Monnier [this message]
2020-01-31 0:44 ` Federico Tedin
2020-01-31 9:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsgjxdnyd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=39291@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
--cc=juri@linkov.net \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).