From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#5293: 23.1; unload-feature on buffer-local hooks Date: Mon, 06 Apr 2020 14:06:02 -0400 Message-ID: References: <87hbr4p67t.fsf@blah.blah> <871uxsl778.fsf@blah.blah> <87aabnnxna.fsf@blah.blah> <87zhbojzmv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="3446"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juanma Barranquero , Kevin Ryde , 5293@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 06 20:16:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLWId-0000mF-Jf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Apr 2020 20:16:43 +0200 Original-Received: from localhost ([::1]:36476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLWIc-0003UY-Fi for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Apr 2020 14:16:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41174) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLW9H-0002Qn-TH for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2020 14:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLW9G-0005iJ-TG for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2020 14:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37642) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLW9G-0005hz-NB for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2020 14:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jLW9G-0004NK-H0 for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2020 14:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Apr 2020 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5293 X-GNU-PR-Package: emacs Original-Received: via spool by 5293-submit@debbugs.gnu.org id=B5293.158619637216651 (code B ref 5293); Mon, 06 Apr 2020 18:07:02 +0000 Original-Received: (at 5293) by debbugs.gnu.org; 6 Apr 2020 18:06:12 +0000 Original-Received: from localhost ([127.0.0.1]:49188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLW8R-0004KV-U9 for submit@debbugs.gnu.org; Mon, 06 Apr 2020 14:06:12 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLW8Q-0004K4-3Q for 5293@debbugs.gnu.org; Mon, 06 Apr 2020 14:06:11 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 823FC44FD2D; Mon, 6 Apr 2020 14:06:04 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0572544FD2A; Mon, 6 Apr 2020 14:06:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1586196363; bh=WmuT7K7Mg+ftM6GqUHavZufjxYjrbAyBKNFffZNmRco=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lnay1FZmWaSYSoY4RFsScnQ6rQdFjnj6FOcdc8/azQM/j4bX/ysRYJg4ohIxRWbDv rSC0rVjPNWpmwDuD/9LLH+9pKLSKPoIEI9xlczwdhtjiN/gPtc6eLYRHZ7KV5Z+XE0 ZUXVe51sKT4ajuOxvQixf5bkKa8Kw/qD/EYcdssQ3XjlIM/hoY/sjW7GpatyVw68oi W84Kb364M7doGOkYXlSX3XfYtkbtgjn5SPT5LL7fqazuj2g/H6lEYRnaLLkLEhBMeG E/X6p/nFSB66COCPXq9MM5bU/gv8jN9H+ugzqSIWpYvjup0GQxIGe8DaBuN9AfuTXV tZy3s9gJXWnvg== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B079C12068D; Mon, 6 Apr 2020 14:06:02 -0400 (EDT) In-Reply-To: <87zhbojzmv.fsf@gmail.com> ("=?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?="'s message of "Mon, 06 Apr 2020 19:24:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178095 Archived-At: > @@ -299,7 +299,11 @@ unload-feature > ;; Known abnormal hooks etc. > (memq x unload-feature-special-hooks))) > (dolist (func removables) > - (remove-hook x func))))) > + (remove-hook x func) > + (save-current-buffer > + (dolist (buffer (buffer-list)) > + (set-buffer buffer) > + (remove-hook x func t))))))) > ;; Remove any feature-symbols from auto-mode-alist as well. > (dolist (func removables) > (setq auto-mode-alist Maybe instead of `(dolist (buffer (buffer-list))` within that big `mapatoms` within `(dolist (func removables)` (which is O(B*F*V) where B is the number of buffers, F is the number of functions and V is the number of hook vars), we should instead do it as: (dolist (buffer (buffer-list)) (dolist (varvar (buffer-local-variables buffer)) (when (dolist (func removables) (remove-hook func t))))) If we need it to go faster maybe we could also arrange for (add-hook V F ..) to do (cl-pushnew V (get F 'hooks-where-it-has-been-put)). So we could do (let ((relevant-hooks (mapcan (lambda (f) (get F 'hooks-where-it-has-been-put)) funcs))) (dolist (buffer (buffer-list)) (dolist (varvar (buffer-local-variables buffer)) (when (memq var relevant-hooks) (dolist (func removables) (remove-hook func t))))) -- Stefan