From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Date: Wed, 10 Mar 2021 13:41:24 -0500 Message-ID: References: <87y2f0fq8v.fsf@protesilaos.com> <87sg58tkg7.fsf@tcd.ie> <87h7lofe6b.fsf@protesilaos.com> <87mtvfpgf2.fsf@protesilaos.com> <878s6wqq40.fsf@tcd.ie> <874khk6t7d.fsf@protesilaos.com> <87mtvb1s3r.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32506"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 46964@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 10 19:42:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK3nI-0008M4-NR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 19:42:52 +0100 Original-Received: from localhost ([::1]:46280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK3nH-0006ja-Nv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 13:42:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK3mU-0006fY-GK for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 13:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40302) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lK3mU-0005w2-8t for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 13:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lK3mU-0004uC-4A for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 13:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46964-submit@debbugs.gnu.org id=B46964.161540171418842 (code B ref 46964); Wed, 10 Mar 2021 18:42:02 +0000 Original-Received: (at 46964) by debbugs.gnu.org; 10 Mar 2021 18:41:54 +0000 Original-Received: from localhost ([127.0.0.1]:51848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK3mH-0004tk-VS for submit@debbugs.gnu.org; Wed, 10 Mar 2021 13:41:54 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK3m1-0004tI-MX for 46964@debbugs.gnu.org; Wed, 10 Mar 2021 13:41:48 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 37568100250; Wed, 10 Mar 2021 13:41:28 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3D42E100225; Wed, 10 Mar 2021 13:41:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615401686; bh=qRseL8VhAwKVAf5PXgmXvxjLQZvS+dOQXYU3NxMt36c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PLIShoSvW24LC+WdmH6Vr8SJEQJlslOMTjelOCZDBRLbkttFRU2vq5xOZFiYmRNyq kXTzJQjHSb85pAYItjlLqta4jYm9gxjJgpz7521EH2E8/KqBuNJrDmv8zIBC39S5zI TxdGj5sVjdX98R+QT2ow3clkuKF6fMRCarIkD+ZI+4qNMphNtpjXq1ypbyuuIYXVGm Ph/MLKgrAhsIGdJdlRH4Qe/IHJlHz5zmiBmBjKhO0lr1scJ2mlu9cVAph4PW4Q7sGt xLvaS2omFgaQ83fCgAeueJ1m8SzdfYm0EJRtrr9x5vm9gmB6sumyLDDG/9fzJQeChy 1+AKEZVOOVFNw== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7D4971202BB; Wed, 10 Mar 2021 13:41:25 -0500 (EST) In-Reply-To: <87mtvb1s3r.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Wed, 10 Mar 2021 07:43:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202026 Archived-At: > While in archive-devel, the Org file is present, though the Info file is > practically empty: > > drwxr-xr-x prot/prot 0 modus-themes-1.2.3.0.20210306.91600/ > -rw-r--r-- prot/prot 122691 modus-themes-1.2.3.0.20210306.91600/modus-themes.org > -rw-r--r-- prot/prot 2550 modus-themes-1.2.3.0.20210306.91600/modus-operandi-theme.el > -rw-r--r-- prot/prot 541 modus-themes-1.2.3.0.20210306.91600/dir > -rw-r--r-- prot/prot 2544 modus-themes-1.2.3.0.20210306.91600/modus-vivendi-theme.el > -rw-r--r-- prot/prot 414 modus-themes-1.2.3.0.20210306.91600/modus-themes-pkg.el > -rw-r--r-- prot/prot 343994 modus-themes-1.2.3.0.20210306.91600/modus-themes.el > -rw-r--r-- prot/prot 218 modus-themes-1.2.3.0.20210306.91600/modus-themes.info Hmm... I made further changes to elpa-admin.el to handle this case. Here were the problems I encountered: - The .texi file generated by Org was basically empty because the .org file that Org saw was literally empty (a symlink pointing nowhere), because the `emacs` subdir was not included in the sandbox. - After adding the `emacs` subdir to the sandbox the problem was that Emacs followed the symlink to the `emacs` subdir and then Org tried to generate ../emacs/doc/misc/modus-themes.texi into ../packages/modus-themes/modus-themes.texi. - After preventing Emacs to follow symlinks Org generated a proper .texi but makeinfo complained of a missing doclicense.texi, so I had to add "doc/misc/doclicense.texi" to the :core keyword. I believe it should work now. Please try again, Stefan