From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#44822: 27.1; Regression in `ffap-read-file-or-url' Date: Sat, 31 Jul 2021 12:47:36 -0400 Message-ID: References: <83pn44ufhd.fsf@gnu.org> <871r7eir8w.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9726"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , 44822@debbugs.gnu.org, Drew Adams , Thierry Volpiatto To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 31 18:48:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9s9h-0002KH-KY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 18:48:09 +0200 Original-Received: from localhost ([::1]:33428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9s9g-0008SD-JN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 12:48:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9s9a-0008S4-Ix for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9s9a-0007jH-BX for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9s9a-0005Rx-Aq for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jul 2021 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44822 X-GNU-PR-Package: emacs Original-Received: via spool by 44822-submit@debbugs.gnu.org id=B44822.162775006720691 (code B ref 44822); Sat, 31 Jul 2021 16:48:02 +0000 Original-Received: (at 44822) by debbugs.gnu.org; 31 Jul 2021 16:47:47 +0000 Original-Received: from localhost ([127.0.0.1]:34751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9s9K-0005NN-Cw for submit@debbugs.gnu.org; Sat, 31 Jul 2021 12:47:46 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9s9H-0005J1-Te for 44822@debbugs.gnu.org; Sat, 31 Jul 2021 12:47:44 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4D17880436; Sat, 31 Jul 2021 12:47:38 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2A6258089C; Sat, 31 Jul 2021 12:47:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1627750057; bh=lc+lU8+mFA9lFq1v5IlpwYvVzk51pKG5eGWQQwJWTHA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZfVjwM2DO3auvh7PRKwTJA1F5OcT7ksYni0M+8esr+P883EHrlm6d+bnjjYQnVB4N dilSvE/YL5ewLb5gJGCUVmHXoCdNM8Cqk/IbEgogpi9O8uVeN4po+Le1ybV7H+ke3N RqRXgt7P0rPgTxLhrPV9Ph9+Y25Onu1VHln8buLs6JR6fRk8yyxMwGDclKAfhgrD6j 8l9R3PlOjtZ1tEtz7Df9xPBgM6HkZGA3SwVqt3uW4KoZcox16NuNm2GHbyMDYvN/di hrCxNgc/ZXx5l7TjNICL8FuSeDDcUwSiRXKzIZy/IEwpGfaNby6v+Sb0KXWKGaJGn4 sgleVtsUs/bWQ== Original-Received: from alfajor (unknown [216.154.29.138]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DDE471201C1; Sat, 31 Jul 2021 12:47:36 -0400 (EDT) In-Reply-To: <871r7eir8w.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 31 Jul 2021 14:48:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211008 Archived-At: Lars Ingebrigtsen [2021-07-31 14:48:15] wrote: > Eli Zaretskii writes: >> Thierry and Stefan, these changes seem to have been done by you. Can >> you please take a look at this issue? > I don't understand the changes either. > With (ffap-read-file-or-url "Url: " nil) it's now currently impossible > to enter an URL after this change: > > commit 8685db187b891bcadcf61e41dea3124e4c45b7d4 > Author: Stefan Monnier > AuthorDate: Sat Nov 9 13:32:20 2019 -0500 > > * lisp/ffap.el (ffap-read-file-or-url): Don't use url-file-handler > > Stefan? Hmm... the motivation for the change is described in the comment: ;; FIXME: We earlier tried to make use of `url-file-handler' so ;; `read-file-name' could also be used for URLs, but it ;; introduced all kinds of subtle breakage such as: ;; - (file-name-directory "http://a") returning "http://a/" ;; - Trying to contact remote hosts with no justification ;; These should be fixed in url-handler-mode before we can try ;; using it here again. Maybe the cure is worse than the disease, Stefan